All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-14  9:49 ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: Wolfram Sang, Kevin Hilman, Carlo Caione
  Cc: Jerome Brunet, linux-amlogic, linux-arm-kernel, linux-i2c,
	Neil Armstrong

This patchset adds a specific compatible string in the Meson I2C driver
for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete
the i2c support on meson gxbb

Neil Armstrong (2):
  i2c: meson: add gxbb compatible string
  dt-bindings: i2c-meson: add gxbb compatible string

 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 drivers/i2c/busses/i2c-meson.c                      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-14  9:49 ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linux-arm-kernel

This patchset adds a specific compatible string in the Meson I2C driver
for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete
the i2c support on meson gxbb

Neil Armstrong (2):
  i2c: meson: add gxbb compatible string
  dt-bindings: i2c-meson: add gxbb compatible string

 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 drivers/i2c/busses/i2c-meson.c                      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-14  9:49 ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linus-amlogic

This patchset adds a specific compatible string in the Meson I2C driver
for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete
the i2c support on meson gxbb

Neil Armstrong (2):
  i2c: meson: add gxbb compatible string
  dt-bindings: i2c-meson: add gxbb compatible string

 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 drivers/i2c/busses/i2c-meson.c                      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 1/2] i2c: meson: add gxbb compatible string
  2016-09-14  9:49 ` Jerome Brunet
  (?)
@ 2016-09-14  9:49   ` Jerome Brunet
  -1 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: Wolfram Sang, Kevin Hilman, Carlo Caione
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-i2c,
	Jerome Brunet

From: Neil Armstrong <narmstrong@baylibre.com>

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/i2c/busses/i2c-meson.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 76e28980904f..30977e31cd98 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
 
 static const struct of_device_id meson_i2c_match[] = {
 	{ .compatible = "amlogic,meson6-i2c" },
+	{ .compatible = "amlogic,meson-gxbb-i2c" },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, meson_i2c_match);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 1/2] i2c: meson: add gxbb compatible string
@ 2016-09-14  9:49   ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linux-arm-kernel

From: Neil Armstrong <narmstrong@baylibre.com>

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/i2c/busses/i2c-meson.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 76e28980904f..30977e31cd98 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
 
 static const struct of_device_id meson_i2c_match[] = {
 	{ .compatible = "amlogic,meson6-i2c" },
+	{ .compatible = "amlogic,meson-gxbb-i2c" },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, meson_i2c_match);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 1/2] i2c: meson: add gxbb compatible string
@ 2016-09-14  9:49   ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linus-amlogic

From: Neil Armstrong <narmstrong@baylibre.com>

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/i2c/busses/i2c-meson.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 76e28980904f..30977e31cd98 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
 
 static const struct of_device_id meson_i2c_match[] = {
 	{ .compatible = "amlogic,meson6-i2c" },
+	{ .compatible = "amlogic,meson-gxbb-i2c" },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, meson_i2c_match);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
  2016-09-14  9:49 ` Jerome Brunet
  (?)
@ 2016-09-14  9:49     ` Jerome Brunet
  -1 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: Wolfram Sang, Kevin Hilman, Carlo Caione,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: Neil Armstrong, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Jerome Brunet

From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Signed-off-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
index 682f9a6f766e..386357d1aab0 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
@@ -1,7 +1,7 @@
 Amlogic Meson I2C controller
 
 Required properties:
- - compatible: must be "amlogic,meson6-i2c"
+ - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
  - reg: physical address and length of the device registers
  - interrupts: a single interrupt specifier
  - clocks: clock for the device
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
@ 2016-09-14  9:49     ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linux-arm-kernel

From: Neil Armstrong <narmstrong@baylibre.com>

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
index 682f9a6f766e..386357d1aab0 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
@@ -1,7 +1,7 @@
 Amlogic Meson I2C controller
 
 Required properties:
- - compatible: must be "amlogic,meson6-i2c"
+ - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
  - reg: physical address and length of the device registers
  - interrupts: a single interrupt specifier
  - clocks: clock for the device
-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
@ 2016-09-14  9:49     ` Jerome Brunet
  0 siblings, 0 replies; 36+ messages in thread
From: Jerome Brunet @ 2016-09-14  9:49 UTC (permalink / raw)
  To: linus-amlogic

From: Neil Armstrong <narmstrong@baylibre.com>

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
index 682f9a6f766e..386357d1aab0 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
@@ -1,7 +1,7 @@
 Amlogic Meson I2C controller
 
 Required properties:
- - compatible: must be "amlogic,meson6-i2c"
+ - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
  - reg: physical address and length of the device registers
  - interrupts: a single interrupt specifier
  - clocks: clock for the device
-- 
2.7.4

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 1/2] i2c: meson: add gxbb compatible string
  2016-09-14  9:49   ` Jerome Brunet
  (?)
@ 2016-09-14 15:19     ` Kevin Hilman
  -1 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Wolfram Sang, Carlo Caione, Neil Armstrong, linux-amlogic,
	linux-arm-kernel, linux-i2c

Jerome Brunet <jbrunet@baylibre.com> writes:

> From: Neil Armstrong <narmstrong@baylibre.com>
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/i2c/busses/i2c-meson.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 76e28980904f..30977e31cd98 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
>  
>  static const struct of_device_id meson_i2c_match[] = {
>  	{ .compatible = "amlogic,meson6-i2c" },
> +	{ .compatible = "amlogic,meson-gxbb-i2c" },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, meson_i2c_match);

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 1/2] i2c: meson: add gxbb compatible string
@ 2016-09-14 15:19     ` Kevin Hilman
  0 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: linux-arm-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> From: Neil Armstrong <narmstrong@baylibre.com>
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/i2c/busses/i2c-meson.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 76e28980904f..30977e31cd98 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
>  
>  static const struct of_device_id meson_i2c_match[] = {
>  	{ .compatible = "amlogic,meson6-i2c" },
> +	{ .compatible = "amlogic,meson-gxbb-i2c" },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, meson_i2c_match);

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 1/2] i2c: meson: add gxbb compatible string
@ 2016-09-14 15:19     ` Kevin Hilman
  0 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: linus-amlogic

Jerome Brunet <jbrunet@baylibre.com> writes:

> From: Neil Armstrong <narmstrong@baylibre.com>
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/i2c/busses/i2c-meson.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 76e28980904f..30977e31cd98 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
>  
>  static const struct of_device_id meson_i2c_match[] = {
>  	{ .compatible = "amlogic,meson6-i2c" },
> +	{ .compatible = "amlogic,meson-gxbb-i2c" },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, meson_i2c_match);

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
  2016-09-14  9:49     ` Jerome Brunet
  (?)
@ 2016-09-14 15:19         ` Kevin Hilman
  -1 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Wolfram Sang, Carlo Caione, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Neil Armstrong, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA

Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> writes:

> From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

Acked-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> index 682f9a6f766e..386357d1aab0 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> @@ -1,7 +1,7 @@
>  Amlogic Meson I2C controller
>  
>  Required properties:
> - - compatible: must be "amlogic,meson6-i2c"
> + - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
>   - reg: physical address and length of the device registers
>   - interrupts: a single interrupt specifier
>   - clocks: clock for the device
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
@ 2016-09-14 15:19         ` Kevin Hilman
  0 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: linux-arm-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> From: Neil Armstrong <narmstrong@baylibre.com>
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> index 682f9a6f766e..386357d1aab0 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> @@ -1,7 +1,7 @@
>  Amlogic Meson I2C controller
>  
>  Required properties:
> - - compatible: must be "amlogic,meson6-i2c"
> + - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
>   - reg: physical address and length of the device registers
>   - interrupts: a single interrupt specifier
>   - clocks: clock for the device

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 2/2] dt-bindings: i2c-meson: add gxbb compatible string
@ 2016-09-14 15:19         ` Kevin Hilman
  0 siblings, 0 replies; 36+ messages in thread
From: Kevin Hilman @ 2016-09-14 15:19 UTC (permalink / raw)
  To: linus-amlogic

Jerome Brunet <jbrunet@baylibre.com> writes:

> From: Neil Armstrong <narmstrong@baylibre.com>
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> index 682f9a6f766e..386357d1aab0 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> @@ -1,7 +1,7 @@
>  Amlogic Meson I2C controller
>  
>  Required properties:
> - - compatible: must be "amlogic,meson6-i2c"
> + - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
>   - reg: physical address and length of the device registers
>   - interrupts: a single interrupt specifier
>   - clocks: clock for the device

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-14  9:49 ` Jerome Brunet
  (?)
@ 2016-09-15 19:41   ` Wolfram Sang
  -1 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-15 19:41 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Kevin Hilman, Carlo Caione, linux-amlogic, linux-arm-kernel,
	linux-i2c, Neil Armstrong

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> This patchset adds a specific compatible string in the Meson I2C driver
> for the Amlogic Meson gxbb SoC.
> 
> Other patch series (pinctrl and device tree) are being sent to complete
> the i2c support on meson gxbb
> 
> Neil Armstrong (2):
>   i2c: meson: add gxbb compatible string
>   dt-bindings: i2c-meson: add gxbb compatible string

Squashed both patches and applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-15 19:41   ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-15 19:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> This patchset adds a specific compatible string in the Meson I2C driver
> for the Amlogic Meson gxbb SoC.
> 
> Other patch series (pinctrl and device tree) are being sent to complete
> the i2c support on meson gxbb
> 
> Neil Armstrong (2):
>   i2c: meson: add gxbb compatible string
>   dt-bindings: i2c-meson: add gxbb compatible string

Squashed both patches and applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160915/7caf8a41/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-15 19:41   ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-15 19:41 UTC (permalink / raw)
  To: linus-amlogic

On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> This patchset adds a specific compatible string in the Meson I2C driver
> for the Amlogic Meson gxbb SoC.
> 
> Other patch series (pinctrl and device tree) are being sent to complete
> the i2c support on meson gxbb
> 
> Neil Armstrong (2):
>   i2c: meson: add gxbb compatible string
>   dt-bindings: i2c-meson: add gxbb compatible string

Squashed both patches and applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20160915/7caf8a41/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-15 19:41   ` Wolfram Sang
  (?)
@ 2016-09-23 15:01     ` Rob Herring
  -1 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 15:01 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> This patchset adds a specific compatible string in the Meson I2C driver
>> for the Amlogic Meson gxbb SoC.
>>
>> Other patch series (pinctrl and device tree) are being sent to complete
>> the i2c support on meson gxbb
>>
>> Neil Armstrong (2):
>>   i2c: meson: add gxbb compatible string
>>   dt-bindings: i2c-meson: add gxbb compatible string
>
> Squashed both patches and applied to for-next, thanks!

Please don't squash. We ask people to split DT bindings for a reason
being reviews and bindings may not go thru subsystem maintainers in
the future. It also makes it harder to find things in the archives or
patchwork (as does maintainer fixups of subject lines).

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 15:01     ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 15:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> This patchset adds a specific compatible string in the Meson I2C driver
>> for the Amlogic Meson gxbb SoC.
>>
>> Other patch series (pinctrl and device tree) are being sent to complete
>> the i2c support on meson gxbb
>>
>> Neil Armstrong (2):
>>   i2c: meson: add gxbb compatible string
>>   dt-bindings: i2c-meson: add gxbb compatible string
>
> Squashed both patches and applied to for-next, thanks!

Please don't squash. We ask people to split DT bindings for a reason
being reviews and bindings may not go thru subsystem maintainers in
the future. It also makes it harder to find things in the archives or
patchwork (as does maintainer fixups of subject lines).

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 15:01     ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 15:01 UTC (permalink / raw)
  To: linus-amlogic

On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> This patchset adds a specific compatible string in the Meson I2C driver
>> for the Amlogic Meson gxbb SoC.
>>
>> Other patch series (pinctrl and device tree) are being sent to complete
>> the i2c support on meson gxbb
>>
>> Neil Armstrong (2):
>>   i2c: meson: add gxbb compatible string
>>   dt-bindings: i2c-meson: add gxbb compatible string
>
> Squashed both patches and applied to for-next, thanks!

Please don't squash. We ask people to split DT bindings for a reason
being reviews and bindings may not go thru subsystem maintainers in
the future. It also makes it harder to find things in the archives or
patchwork (as does maintainer fixups of subject lines).

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-23 15:01     ` Rob Herring
  (?)
@ 2016-09-23 22:13       ` Wolfram Sang
  -1 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 22:13 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> >> This patchset adds a specific compatible string in the Meson I2C driver
> >> for the Amlogic Meson gxbb SoC.
> >>
> >> Other patch series (pinctrl and device tree) are being sent to complete
> >> the i2c support on meson gxbb
> >>
> >> Neil Armstrong (2):
> >>   i2c: meson: add gxbb compatible string
> >>   dt-bindings: i2c-meson: add gxbb compatible string
> >
> > Squashed both patches and applied to for-next, thanks!
> 
> Please don't squash. We ask people to split DT bindings for a reason
> being reviews and bindings may not go thru subsystem maintainers in
> the future. It also makes it harder to find things in the archives or
> patchwork (as does maintainer fixups of subject lines).

I intentionally don't ask people to send me the patches squashed. So,
you will have them seperate in patchwork et al. I only squash them just
before commiting to my tree. That's because I found that when digging
through git history, it is much more convenient to have all the
information in one commit.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 22:13       ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 22:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> >> This patchset adds a specific compatible string in the Meson I2C driver
> >> for the Amlogic Meson gxbb SoC.
> >>
> >> Other patch series (pinctrl and device tree) are being sent to complete
> >> the i2c support on meson gxbb
> >>
> >> Neil Armstrong (2):
> >>   i2c: meson: add gxbb compatible string
> >>   dt-bindings: i2c-meson: add gxbb compatible string
> >
> > Squashed both patches and applied to for-next, thanks!
> 
> Please don't squash. We ask people to split DT bindings for a reason
> being reviews and bindings may not go thru subsystem maintainers in
> the future. It also makes it harder to find things in the archives or
> patchwork (as does maintainer fixups of subject lines).

I intentionally don't ask people to send me the patches squashed. So,
you will have them seperate in patchwork et al. I only squash them just
before commiting to my tree. That's because I found that when digging
through git history, it is much more convenient to have all the
information in one commit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160924/4c831195/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 22:13       ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 22:13 UTC (permalink / raw)
  To: linus-amlogic

On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
> >> This patchset adds a specific compatible string in the Meson I2C driver
> >> for the Amlogic Meson gxbb SoC.
> >>
> >> Other patch series (pinctrl and device tree) are being sent to complete
> >> the i2c support on meson gxbb
> >>
> >> Neil Armstrong (2):
> >>   i2c: meson: add gxbb compatible string
> >>   dt-bindings: i2c-meson: add gxbb compatible string
> >
> > Squashed both patches and applied to for-next, thanks!
> 
> Please don't squash. We ask people to split DT bindings for a reason
> being reviews and bindings may not go thru subsystem maintainers in
> the future. It also makes it harder to find things in the archives or
> patchwork (as does maintainer fixups of subject lines).

I intentionally don't ask people to send me the patches squashed. So,
you will have them seperate in patchwork et al. I only squash them just
before commiting to my tree. That's because I found that when digging
through git history, it is much more convenient to have all the
information in one commit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20160924/4c831195/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-23 22:13       ` Wolfram Sang
  (?)
@ 2016-09-23 23:04         ` Rob Herring
  -1 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 23:04 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

On Fri, Sep 23, 2016 at 5:13 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
>> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> >> This patchset adds a specific compatible string in the Meson I2C driver
>> >> for the Amlogic Meson gxbb SoC.
>> >>
>> >> Other patch series (pinctrl and device tree) are being sent to complete
>> >> the i2c support on meson gxbb
>> >>
>> >> Neil Armstrong (2):
>> >>   i2c: meson: add gxbb compatible string
>> >>   dt-bindings: i2c-meson: add gxbb compatible string
>> >
>> > Squashed both patches and applied to for-next, thanks!
>>
>> Please don't squash. We ask people to split DT bindings for a reason
>> being reviews and bindings may not go thru subsystem maintainers in
>> the future. It also makes it harder to find things in the archives or
>> patchwork (as does maintainer fixups of subject lines).
>
> I intentionally don't ask people to send me the patches squashed. So,
> you will have them seperate in patchwork et al. I only squash them just
> before commiting to my tree. That's because I found that when digging
> through git history, it is much more convenient to have all the
> information in one commit.

If git history was the only thing that mattered, then that would be
fine. But it is not. Maintainers should apply what's on the list.
Period. You wouldn't fixup pull requests to make the commit history
more to your liking, would you?

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 23:04         ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 23:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 23, 2016 at 5:13 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
>> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> >> This patchset adds a specific compatible string in the Meson I2C driver
>> >> for the Amlogic Meson gxbb SoC.
>> >>
>> >> Other patch series (pinctrl and device tree) are being sent to complete
>> >> the i2c support on meson gxbb
>> >>
>> >> Neil Armstrong (2):
>> >>   i2c: meson: add gxbb compatible string
>> >>   dt-bindings: i2c-meson: add gxbb compatible string
>> >
>> > Squashed both patches and applied to for-next, thanks!
>>
>> Please don't squash. We ask people to split DT bindings for a reason
>> being reviews and bindings may not go thru subsystem maintainers in
>> the future. It also makes it harder to find things in the archives or
>> patchwork (as does maintainer fixups of subject lines).
>
> I intentionally don't ask people to send me the patches squashed. So,
> you will have them seperate in patchwork et al. I only squash them just
> before commiting to my tree. That's because I found that when digging
> through git history, it is much more convenient to have all the
> information in one commit.

If git history was the only thing that mattered, then that would be
fine. But it is not. Maintainers should apply what's on the list.
Period. You wouldn't fixup pull requests to make the commit history
more to your liking, would you?

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 23:04         ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-23 23:04 UTC (permalink / raw)
  To: linus-amlogic

On Fri, Sep 23, 2016 at 5:13 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Fri, Sep 23, 2016 at 10:01:13AM -0500, Rob Herring wrote:
>> On Thu, Sep 15, 2016 at 2:41 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> > On Wed, Sep 14, 2016 at 11:49:15AM +0200, Jerome Brunet wrote:
>> >> This patchset adds a specific compatible string in the Meson I2C driver
>> >> for the Amlogic Meson gxbb SoC.
>> >>
>> >> Other patch series (pinctrl and device tree) are being sent to complete
>> >> the i2c support on meson gxbb
>> >>
>> >> Neil Armstrong (2):
>> >>   i2c: meson: add gxbb compatible string
>> >>   dt-bindings: i2c-meson: add gxbb compatible string
>> >
>> > Squashed both patches and applied to for-next, thanks!
>>
>> Please don't squash. We ask people to split DT bindings for a reason
>> being reviews and bindings may not go thru subsystem maintainers in
>> the future. It also makes it harder to find things in the archives or
>> patchwork (as does maintainer fixups of subject lines).
>
> I intentionally don't ask people to send me the patches squashed. So,
> you will have them seperate in patchwork et al. I only squash them just
> before commiting to my tree. That's because I found that when digging
> through git history, it is much more convenient to have all the
> information in one commit.

If git history was the only thing that mattered, then that would be
fine. But it is not. Maintainers should apply what's on the list.
Period. You wouldn't fixup pull requests to make the commit history
more to your liking, would you?

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-23 23:04         ` Rob Herring
  (?)
@ 2016-09-23 23:26           ` Wolfram Sang
  -1 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 23:26 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]


> > I intentionally don't ask people to send me the patches squashed. So,
> > you will have them seperate in patchwork et al. I only squash them just
> > before commiting to my tree. That's because I found that when digging
> > through git history, it is much more convenient to have all the
> > information in one commit.
> 
> If git history was the only thing that mattered, then that would be
> fine. But it is not. Maintainers should apply what's on the list.
> Period.

Huh? If you would *ask* me to stop squashing, I am listening to reasons.
If you want to force arbitrary rules on me, I am not. There are reasons
where squashing/modifying patches makes more sense compared to forcing
the author to resend. DTS bindings may not be one, we can discuss that.
But that rule without allowing exceptions seems impractical to me.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 23:26           ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 23:26 UTC (permalink / raw)
  To: linux-arm-kernel


> > I intentionally don't ask people to send me the patches squashed. So,
> > you will have them seperate in patchwork et al. I only squash them just
> > before commiting to my tree. That's because I found that when digging
> > through git history, it is much more convenient to have all the
> > information in one commit.
> 
> If git history was the only thing that mattered, then that would be
> fine. But it is not. Maintainers should apply what's on the list.
> Period.

Huh? If you would *ask* me to stop squashing, I am listening to reasons.
If you want to force arbitrary rules on me, I am not. There are reasons
where squashing/modifying patches makes more sense compared to forcing
the author to resend. DTS bindings may not be one, we can discuss that.
But that rule without allowing exceptions seems impractical to me.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160924/8e01fc6e/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-23 23:26           ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-23 23:26 UTC (permalink / raw)
  To: linus-amlogic


> > I intentionally don't ask people to send me the patches squashed. So,
> > you will have them seperate in patchwork et al. I only squash them just
> > before commiting to my tree. That's because I found that when digging
> > through git history, it is much more convenient to have all the
> > information in one commit.
> 
> If git history was the only thing that mattered, then that would be
> fine. But it is not. Maintainers should apply what's on the list.
> Period.

Huh? If you would *ask* me to stop squashing, I am listening to reasons.
If you want to force arbitrary rules on me, I am not. There are reasons
where squashing/modifying patches makes more sense compared to forcing
the author to resend. DTS bindings may not be one, we can discuss that.
But that rule without allowing exceptions seems impractical to me.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20160924/8e01fc6e/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-23 23:26           ` Wolfram Sang
  (?)
@ 2016-09-24  1:02             ` Rob Herring
  -1 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-24  1:02 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

On Fri, Sep 23, 2016 at 6:26 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > I intentionally don't ask people to send me the patches squashed. So,
>> > you will have them seperate in patchwork et al. I only squash them just
>> > before commiting to my tree. That's because I found that when digging
>> > through git history, it is much more convenient to have all the
>> > information in one commit.
>>
>> If git history was the only thing that mattered, then that would be
>> fine. But it is not. Maintainers should apply what's on the list.
>> Period.
>
> Huh? If you would *ask* me to stop squashing, I am listening to reasons.

I did state some reasons previously. Consistent rules for submitters
of DT bindings and being able to trace history beyond git. Now, I
guess you aren't changing the rules, but you probably aren't
requesting people to split DT bindings either? You might not be aware,
but we also generate a DT only tree with git-filter-branch[1] for
non-kernel projects to use bindings and dts files. For that, sure they
will only get the DT binding part of it, but what commit text do they
get? Finally, DT maintainer acks (which from me is a review really)
apply to the bindings only. Sometimes I review the drivers, but not
often. So I would like the git history of my reviews to be accurate in
terms of what I actually reviewed.

> If you want to force arbitrary rules on me, I am not. There are reasons
> where squashing/modifying patches makes more sense compared to forcing
> the author to resend. DTS bindings may not be one, we can discuss that.
> But that rule without allowing exceptions seems impractical to me.

Okay, "period" was a bit much. Exceptions are perfectly fine, we all
do some minor fixups time to time. It just shouldn't be the norm IMO.

Rob

[1] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-24  1:02             ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-24  1:02 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 23, 2016 at 6:26 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > I intentionally don't ask people to send me the patches squashed. So,
>> > you will have them seperate in patchwork et al. I only squash them just
>> > before commiting to my tree. That's because I found that when digging
>> > through git history, it is much more convenient to have all the
>> > information in one commit.
>>
>> If git history was the only thing that mattered, then that would be
>> fine. But it is not. Maintainers should apply what's on the list.
>> Period.
>
> Huh? If you would *ask* me to stop squashing, I am listening to reasons.

I did state some reasons previously. Consistent rules for submitters
of DT bindings and being able to trace history beyond git. Now, I
guess you aren't changing the rules, but you probably aren't
requesting people to split DT bindings either? You might not be aware,
but we also generate a DT only tree with git-filter-branch[1] for
non-kernel projects to use bindings and dts files. For that, sure they
will only get the DT binding part of it, but what commit text do they
get? Finally, DT maintainer acks (which from me is a review really)
apply to the bindings only. Sometimes I review the drivers, but not
often. So I would like the git history of my reviews to be accurate in
terms of what I actually reviewed.

> If you want to force arbitrary rules on me, I am not. There are reasons
> where squashing/modifying patches makes more sense compared to forcing
> the author to resend. DTS bindings may not be one, we can discuss that.
> But that rule without allowing exceptions seems impractical to me.

Okay, "period" was a bit much. Exceptions are perfectly fine, we all
do some minor fixups time to time. It just shouldn't be the norm IMO.

Rob

[1] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-24  1:02             ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2016-09-24  1:02 UTC (permalink / raw)
  To: linus-amlogic

On Fri, Sep 23, 2016 at 6:26 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > I intentionally don't ask people to send me the patches squashed. So,
>> > you will have them seperate in patchwork et al. I only squash them just
>> > before commiting to my tree. That's because I found that when digging
>> > through git history, it is much more convenient to have all the
>> > information in one commit.
>>
>> If git history was the only thing that mattered, then that would be
>> fine. But it is not. Maintainers should apply what's on the list.
>> Period.
>
> Huh? If you would *ask* me to stop squashing, I am listening to reasons.

I did state some reasons previously. Consistent rules for submitters
of DT bindings and being able to trace history beyond git. Now, I
guess you aren't changing the rules, but you probably aren't
requesting people to split DT bindings either? You might not be aware,
but we also generate a DT only tree with git-filter-branch[1] for
non-kernel projects to use bindings and dts files. For that, sure they
will only get the DT binding part of it, but what commit text do they
get? Finally, DT maintainer acks (which from me is a review really)
apply to the bindings only. Sometimes I review the drivers, but not
often. So I would like the git history of my reviews to be accurate in
terms of what I actually reviewed.

> If you want to force arbitrary rules on me, I am not. There are reasons
> where squashing/modifying patches makes more sense compared to forcing
> the author to resend. DTS bindings may not be one, we can discuss that.
> But that rule without allowing exceptions seems impractical to me.

Okay, "period" was a bit much. Exceptions are perfectly fine, we all
do some minor fixups time to time. It just shouldn't be the norm IMO.

Rob

[1] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 0/2] i2c: meson: add gxbb compatible string
  2016-09-24  1:02             ` Rob Herring
  (?)
@ 2016-09-24  8:41               ` Wolfram Sang
  -1 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-24  8:41 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jerome Brunet, Neil Armstrong, Kevin Hilman, linux-i2c,
	Carlo Caione, linux-amlogic, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]


> I did state some reasons previously. Consistent rules for submitters
> of DT bindings and being able to trace history beyond git. Now, I
> guess you aren't changing the rules, but you probably aren't
> requesting people to split DT bindings either? You might not be aware,
> but we also generate a DT only tree with git-filter-branch[1] for
> non-kernel projects to use bindings and dts files. For that, sure they
> will only get the DT binding part of it, but what commit text do they
> get? Finally, DT maintainer acks (which from me is a review really)
> apply to the bindings only. Sometimes I review the drivers, but not
> often. So I would like the git history of my reviews to be accurate in
> terms of what I actually reviewed.

Points taken. Will keep them seperate from now on.

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-24  8:41               ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-24  8:41 UTC (permalink / raw)
  To: linux-arm-kernel


> I did state some reasons previously. Consistent rules for submitters
> of DT bindings and being able to trace history beyond git. Now, I
> guess you aren't changing the rules, but you probably aren't
> requesting people to split DT bindings either? You might not be aware,
> but we also generate a DT only tree with git-filter-branch[1] for
> non-kernel projects to use bindings and dts files. For that, sure they
> will only get the DT binding part of it, but what commit text do they
> get? Finally, DT maintainer acks (which from me is a review really)
> apply to the bindings only. Sometimes I review the drivers, but not
> often. So I would like the git history of my reviews to be accurate in
> terms of what I actually reviewed.

Points taken. Will keep them seperate from now on.

Thanks,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160924/b82a4946/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 0/2] i2c: meson: add gxbb compatible string
@ 2016-09-24  8:41               ` Wolfram Sang
  0 siblings, 0 replies; 36+ messages in thread
From: Wolfram Sang @ 2016-09-24  8:41 UTC (permalink / raw)
  To: linus-amlogic


> I did state some reasons previously. Consistent rules for submitters
> of DT bindings and being able to trace history beyond git. Now, I
> guess you aren't changing the rules, but you probably aren't
> requesting people to split DT bindings either? You might not be aware,
> but we also generate a DT only tree with git-filter-branch[1] for
> non-kernel projects to use bindings and dts files. For that, sure they
> will only get the DT binding part of it, but what commit text do they
> get? Finally, DT maintainer acks (which from me is a review really)
> apply to the bindings only. Sometimes I review the drivers, but not
> often. So I would like the git history of my reviews to be accurate in
> terms of what I actually reviewed.

Points taken. Will keep them seperate from now on.

Thanks,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20160924/b82a4946/attachment.sig>

^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2016-09-24  8:42 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  9:49 [PATCH 0/2] i2c: meson: add gxbb compatible string Jerome Brunet
2016-09-14  9:49 ` Jerome Brunet
2016-09-14  9:49 ` Jerome Brunet
2016-09-14  9:49 ` [PATCH 1/2] " Jerome Brunet
2016-09-14  9:49   ` Jerome Brunet
2016-09-14  9:49   ` Jerome Brunet
2016-09-14 15:19   ` Kevin Hilman
2016-09-14 15:19     ` Kevin Hilman
2016-09-14 15:19     ` Kevin Hilman
     [not found] ` <1473846557-18123-1-git-send-email-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-09-14  9:49   ` [PATCH 2/2] dt-bindings: i2c-meson: " Jerome Brunet
2016-09-14  9:49     ` Jerome Brunet
2016-09-14  9:49     ` Jerome Brunet
     [not found]     ` <1473846557-18123-3-git-send-email-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-09-14 15:19       ` Kevin Hilman
2016-09-14 15:19         ` Kevin Hilman
2016-09-14 15:19         ` Kevin Hilman
2016-09-15 19:41 ` [PATCH 0/2] i2c: meson: " Wolfram Sang
2016-09-15 19:41   ` Wolfram Sang
2016-09-15 19:41   ` Wolfram Sang
2016-09-23 15:01   ` Rob Herring
2016-09-23 15:01     ` Rob Herring
2016-09-23 15:01     ` Rob Herring
2016-09-23 22:13     ` Wolfram Sang
2016-09-23 22:13       ` Wolfram Sang
2016-09-23 22:13       ` Wolfram Sang
2016-09-23 23:04       ` Rob Herring
2016-09-23 23:04         ` Rob Herring
2016-09-23 23:04         ` Rob Herring
2016-09-23 23:26         ` Wolfram Sang
2016-09-23 23:26           ` Wolfram Sang
2016-09-23 23:26           ` Wolfram Sang
2016-09-24  1:02           ` Rob Herring
2016-09-24  1:02             ` Rob Herring
2016-09-24  1:02             ` Rob Herring
2016-09-24  8:41             ` Wolfram Sang
2016-09-24  8:41               ` Wolfram Sang
2016-09-24  8:41               ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.