From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com
Subject: [v4l-utils PATCH v1.2 2/2] media-ctl: Print information related to a single entity
Date: Wed, 14 Sep 2016 17:29:39 +0300 [thread overview]
Message-ID: <1473863379-4875-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <2226876.Vxqef30rz5@avalon>
Add a possibility to printing all information related to a given entity by
using both -p and -e options. This may be handy sometimes if only a single
entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Fixed the commit message as well.
utils/media-ctl/media-ctl.c | 33 +++++++++++++++------------------
utils/media-ctl/options.c | 2 ++
2 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/utils/media-ctl/media-ctl.c b/utils/media-ctl/media-ctl.c
index 0499008..109cc11 100644
--- a/utils/media-ctl/media-ctl.c
+++ b/utils/media-ctl/media-ctl.c
@@ -504,19 +504,11 @@ static void media_print_topology_text(struct media_device *media)
media, media_get_entity(media, i));
}
-void media_print_topology(struct media_device *media, int dot)
-{
- if (dot)
- media_print_topology_dot(media);
- else
- media_print_topology_text(media);
-}
-
int main(int argc, char **argv)
{
struct media_device *media;
+ struct media_entity *entity = NULL;
int ret = -1;
- const char *devname;
if (parse_cmdline(argc, argv))
return EXIT_FAILURE;
@@ -562,17 +554,11 @@ int main(int argc, char **argv)
}
if (media_opts.entity) {
- struct media_entity *entity;
-
entity = media_get_entity_by_name(media, media_opts.entity);
if (entity == NULL) {
printf("Entity '%s' not found\n", media_opts.entity);
goto out;
}
-
- devname = media_entity_get_devname(entity);
- if (devname)
- printf("%s\n", devname);
}
if (media_opts.fmt_pad) {
@@ -611,9 +597,20 @@ int main(int argc, char **argv)
}
}
- if (media_opts.print || media_opts.print_dot) {
- media_print_topology(media, media_opts.print_dot);
- printf("\n");
+ if (media_opts.print_dot) {
+ media_print_topology_dot(media);
+ } else if (media_opts.print) {
+ if (entity) {
+ media_print_topology_text_entity(media, entity);
+ } else {
+ media_print_topology_text(media);
+ }
+ } else if (entity) {
+ const char *devname;
+
+ devname = media_entity_get_devname(entity);
+ if (devname)
+ printf("%s\n", devname);
}
if (media_opts.reset) {
diff --git a/utils/media-ctl/options.c b/utils/media-ctl/options.c
index a288a1b..304a86c 100644
--- a/utils/media-ctl/options.c
+++ b/utils/media-ctl/options.c
@@ -52,6 +52,8 @@ static void usage(const char *argv0)
printf("-l, --links links Comma-separated list of link descriptors to setup\n");
printf(" --known-mbus-fmts List known media bus formats and their numeric values\n");
printf("-p, --print-topology Print the device topology\n");
+ printf(" If entity name is specified using -e option, information\n");
+ printf(" related to that entity only is printed.\n");
printf(" --print-dot Print the device topology as a dot graph\n");
printf("-r, --reset Reset all links to inactive\n");
printf("-v, --verbose Be verbose\n");
--
2.7.4
next prev parent reply other threads:[~2016-09-14 14:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:28 [v4l-utils PATCH 0/2] Print information on given entity only Sakari Ailus
2016-09-13 8:28 ` [v4l-utils PATCH 1/2] media-ctl: Split off printing information related to a single entity Sakari Ailus
2016-09-13 23:34 ` Laurent Pinchart
2016-09-13 8:28 ` [v4l-utils PATCH 2/2] media-ctl: Print " Sakari Ailus
2016-09-13 23:41 ` Laurent Pinchart
2016-09-14 14:27 ` [v4l-utils PATCH v1.1 " Sakari Ailus
2016-09-14 14:29 ` Sakari Ailus [this message]
2016-09-14 22:05 ` [v4l-utils PATCH v1.2 " Laurent Pinchart
2016-09-15 6:39 ` Sakari Ailus
2016-09-15 6:40 ` [v4l-utils PATCH v1.3 " Sakari Ailus
2016-09-15 8:10 ` Laurent Pinchart
2016-09-15 8:15 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473863379-4875-1-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.