From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@vger.kernel.org>
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40419 "EHLO
        relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1762137AbcINPpB (ORCPT
        <rfc822;linux-iio@vger.kernel.org>); Wed, 14 Sep 2016 11:45:01 -0400
Message-ID: <1473867872.6389.16.camel@hadess.net>
Subject: Re: possible odd acceleration scaling
From: Bastien Nocera <hadess@hadess.net>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        rrs@researchut.com, Jonathan Cameron <jic23@kernel.org>,
        linux-iio@vger.kernel.org
Date: Wed, 14 Sep 2016 17:44:32 +0200
In-Reply-To: <1473866880.35049.5.camel@linux.intel.com>
References: <1473787814.8047.8.camel@researchut.com>
         <a9078c9f-0d07-35bc-e449-2cfeee7b7987@kernel.org>
         <d275ff67-4335-a6f4-b60b-c4227a59b34c@kernel.org>
         <1473793566.6874.10.camel@linux.intel.com>
         <1473843953.23872.3.camel@researchut.com>
         <1473845312.23872.5.camel@researchut.com>
         <1473861009.9913.7.camel@researchut.com>
         <1473866880.35049.5.camel@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-iio-owner@vger.kernel.org
List-Id: linux-iio@vger.kernel.org

On Wed, 2016-09-14 at 08:28 -0700, Srinivas Pandruvada wrote:
> On Wed, 2016-09-14 at 19:20 +0530, Ritesh Raj Sarraf wrote:
> Hello Srinivas,
> 
> On Wed, 2016-09-14 at 14:58 +0530, Ritesh Raj Sarraf wrote:
> > 
> >  
> > And linked are debug logs with both, 1.1 and 1.2
> > 
> > https://people.debian.org/~rrs/tmp/1.1.log
> > https://people.debian.org/~rrs/tmp/1.2.log
> > 
> 
> 
> After reverting your changes[1], and applying Bastien's change [2],
> it is better
> as in now it can detect all orientation types. But they do not align
> with the
> actual physical orientation of the device. They are flipped to the
> actual
> orientation of the device. Logs linked [3]. Tested on Linux 4.8-rc6
> 
> rrs@learner:/var/tmp/Debian-Build/Result$ monitor-sensor 
>     Waiting for iio-sensor-proxy to appear
> +++ iio-sensor-proxy appeared
> === Has accelerometer (orientation: right-up)
> === Has ambient light sensor (value: 0.000000, unit: lux)
>     Accelerometer orientation changed: normal
>     Accelerometer orientation changed: right-up
>     Accelerometer orientation changed: bottom-up
>     Accelerometer orientation changed: right-up
> 
> 
> I was surprised why the sorting function didn't work (it should be
> qsort compliant). We need some way not to depend on the order of
> scan_elements read from file system. So we need to fix this.

My guess:
-       return (int) (info_1->index - info_2->index);
+       return ((int) info_1->index - (int) info_2->index);

Ritesh, could you try to change those lines in compare_channel_index()
in src/iio-buffer-utils.c and capture another log if it fails?

Cheers