From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bkRHJ-0004G0-A3
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 03:40:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bkRHE-0001wp-Qg
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 03:40:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bkRHE-0001wC-LS
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 03:40:08 -0400
Message-ID: <1473925202.8913.13.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 15 Sep 2016 09:40:02 +0200
In-Reply-To: <1473890265-3304-1-git-send-email-hpoussin@reactos.org>
References: <1473890265-3304-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc
 improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

  Hi,

> - Patches 1 and 2 are fixes to let Linux use set 3 if instructed so.
> - Patch 3 makes scancodes untranslated by default and translates them if =
required,
>   instead of receiving translated scancodes by default and untranslating =
them if
>   required.
> - Patch 4 switches to use qcodes instead of scancodes.
> - Patch 5 is a small cleanup, to prevent sending invalid keycodes to the =
OS.

Nice!

> Patch 3 doesn't pass checkpatch.pl, due to translation table using more t=
han 80 columns.

Easily fixable by breaking those long lines into two.

> Patch 4 doesn't pass checkpatch.pl, due to some key mappings not implemen=
ted because of
> missing an equivalent qcode.

Hmm, yes, I've found the checkpatch warning on "#if 0" annonying in
simliar cases before.  Documenting incomplete translation tables that
way looks reasonable to me ...

Beside that we can consider adding these qcodes to qemu (which shouldn't
block merging this series of course).

cheers,
  Gerd