All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: "Emilio G. Cota" <cota@braap.org>
Subject: [Qemu-devel] [PATCH v4 33/35] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}
Date: Fri, 16 Sep 2016 10:46:55 -0700	[thread overview]
Message-ID: <1474048017-26696-34-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1474048017-26696-1-git-send-email-rth@twiddle.net>

From: "Emilio G. Cota" <cota@braap.org>

The exception is not emitted anymore; remove it and the associated
TCG variables.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Message-Id: <1467054136-10430-31-git-send-email-cota@braap.org>
---
 target-arm/cpu.h       | 17 ++++++-----------
 target-arm/internals.h |  4 +---
 target-arm/translate.c | 10 ----------
 target-arm/translate.h |  4 ----
 4 files changed, 7 insertions(+), 28 deletions(-)

diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 76d824d..a38cec0 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -46,13 +46,12 @@
 #define EXCP_BKPT            7
 #define EXCP_EXCEPTION_EXIT  8   /* Return from v7M exception.  */
 #define EXCP_KERNEL_TRAP     9   /* Jumped to kernel code page.  */
-#define EXCP_STREX          10
-#define EXCP_HVC            11   /* HyperVisor Call */
-#define EXCP_HYP_TRAP       12
-#define EXCP_SMC            13   /* Secure Monitor Call */
-#define EXCP_VIRQ           14
-#define EXCP_VFIQ           15
-#define EXCP_SEMIHOST       16   /* semihosting call (A64 only) */
+#define EXCP_HVC            10   /* HyperVisor Call */
+#define EXCP_HYP_TRAP       11
+#define EXCP_SMC            12   /* Secure Monitor Call */
+#define EXCP_VIRQ           13
+#define EXCP_VFIQ           14
+#define EXCP_SEMIHOST       15   /* semihosting call (A64 only) */
 
 #define ARMV7M_EXCP_RESET   1
 #define ARMV7M_EXCP_NMI     2
@@ -475,10 +474,6 @@ typedef struct CPUARMState {
     uint64_t exclusive_addr;
     uint64_t exclusive_val;
     uint64_t exclusive_high;
-#if defined(CONFIG_USER_ONLY)
-    uint64_t exclusive_test;
-    uint32_t exclusive_info;
-#endif
 
     /* iwMMXt coprocessor state.  */
     struct {
diff --git a/target-arm/internals.h b/target-arm/internals.h
index cd57401..3edccd2 100644
--- a/target-arm/internals.h
+++ b/target-arm/internals.h
@@ -46,8 +46,7 @@ static inline bool excp_is_internal(int excp)
         || excp == EXCP_HALTED
         || excp == EXCP_EXCEPTION_EXIT
         || excp == EXCP_KERNEL_TRAP
-        || excp == EXCP_SEMIHOST
-        || excp == EXCP_STREX;
+        || excp == EXCP_SEMIHOST;
 }
 
 /* Exception names for debug logging; note that not all of these
@@ -63,7 +62,6 @@ static const char * const excnames[] = {
     [EXCP_BKPT] = "Breakpoint",
     [EXCP_EXCEPTION_EXIT] = "QEMU v7M exception exit",
     [EXCP_KERNEL_TRAP] = "QEMU intercept of kernel commpage",
-    [EXCP_STREX] = "QEMU intercept of STREX",
     [EXCP_HVC] = "Hypervisor Call",
     [EXCP_HYP_TRAP] = "Hypervisor Trap",
     [EXCP_SMC] = "Secure Monitor Call",
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 0b35f9e..604f43f 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -64,10 +64,6 @@ static TCGv_i32 cpu_R[16];
 TCGv_i32 cpu_CF, cpu_NF, cpu_VF, cpu_ZF;
 TCGv_i64 cpu_exclusive_addr;
 TCGv_i64 cpu_exclusive_val;
-#ifdef CONFIG_USER_ONLY
-TCGv_i64 cpu_exclusive_test;
-TCGv_i32 cpu_exclusive_info;
-#endif
 
 /* FIXME:  These should be removed.  */
 static TCGv_i32 cpu_F0s, cpu_F1s;
@@ -101,12 +97,6 @@ void arm_translate_init(void)
         offsetof(CPUARMState, exclusive_addr), "exclusive_addr");
     cpu_exclusive_val = tcg_global_mem_new_i64(cpu_env,
         offsetof(CPUARMState, exclusive_val), "exclusive_val");
-#ifdef CONFIG_USER_ONLY
-    cpu_exclusive_test = tcg_global_mem_new_i64(cpu_env,
-        offsetof(CPUARMState, exclusive_test), "exclusive_test");
-    cpu_exclusive_info = tcg_global_mem_new_i32(cpu_env,
-        offsetof(CPUARMState, exclusive_info), "exclusive_info");
-#endif
 
     a64_translate_init();
 }
diff --git a/target-arm/translate.h b/target-arm/translate.h
index dbd7ac8..d4e205e 100644
--- a/target-arm/translate.h
+++ b/target-arm/translate.h
@@ -77,10 +77,6 @@ extern TCGv_env cpu_env;
 extern TCGv_i32 cpu_NF, cpu_ZF, cpu_CF, cpu_VF;
 extern TCGv_i64 cpu_exclusive_addr;
 extern TCGv_i64 cpu_exclusive_val;
-#ifdef CONFIG_USER_ONLY
-extern TCGv_i64 cpu_exclusive_test;
-extern TCGv_i32 cpu_exclusive_info;
-#endif
 
 static inline int arm_dc_feature(DisasContext *dc, int feature)
 {
-- 
2.5.5

  parent reply	other threads:[~2016-09-16 17:48 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 17:46 [Qemu-devel] [PATCH v4 00/35] cmpxchg-based emulation of atomics Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 01/35] atomics: add atomic_xor Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 02/35] atomics: add atomic_op_fetch variants Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 03/35] exec: Avoid direct references to Int128 parts Richard Henderson
2016-10-04  8:44   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 04/35] int128: Use __int128 if available Richard Henderson
2016-10-04  8:45   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 05/35] int128: Add int128_make128 Richard Henderson
2016-10-04  8:46   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 07/35] HACK: Always enable parallel_cpus Richard Henderson
2016-10-04 13:29   ` Alex Bennée
2016-10-05 18:17     ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 08/35] cputlb: Replace SHIFT with DATA_SIZE Richard Henderson
2016-10-04  8:47   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 09/35] cputlb: Move probe_write out of softmmu_template.h Richard Henderson
2016-10-04  8:47   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 10/35] cputlb: Remove includes from softmmu_template.h Richard Henderson
2016-10-04  8:49   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 11/35] cputlb: Move most of iotlb code out of line Richard Henderson
2016-10-04 11:00   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 12/35] cputlb: Tidy some macros Richard Henderson
2016-10-04 11:07   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers Richard Henderson
2016-10-03 19:42   ` Alex Bennée
2016-10-05  0:02     ` Emilio G. Cota
2016-10-05 11:17       ` Alex Bennée
2016-10-05 18:08         ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 14/35] tcg: Add atomic128 helpers Richard Henderson
2016-10-05 11:44   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 15/35] tcg: Add CONFIG_ATOMIC64 Richard Henderson
2016-10-04 15:47   ` Alex Bennée
2016-10-04 15:58     ` Peter Maydell
2016-10-05 17:49     ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 16/35] tcg: Emit barriers with parallel_cpus Richard Henderson
2016-10-05 11:44   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 17/35] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 18/35] target-i386: emulate LOCK'ed OP instructions using atomic helpers Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 19/35] target-i386: emulate LOCK'ed INC using atomic helper Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 20/35] target-i386: emulate LOCK'ed NOT " Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 21/35] target-i386: emulate LOCK'ed NEG using cmpxchg helper Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 22/35] target-i386: emulate LOCK'ed XADD using atomic helper Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 23/35] target-i386: emulate LOCK'ed BTX ops using atomic helpers Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 24/35] target-i386: emulate XCHG using atomic helper Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 25/35] target-i386: remove helper_lock() Richard Henderson
2016-10-05 11:46   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 26/35] tests: add atomic_add-bench Richard Henderson
2016-09-16 23:54   ` Emilio G. Cota
2016-09-16 23:57     ` [Qemu-devel] [PATCH] " Emilio G. Cota
2016-09-17  1:01     ` [Qemu-devel] [PATCH v4 26/35] " Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 27/35] target-arm: Rearrange aa32 load and store functions Richard Henderson
2016-10-05 13:37   ` Alex Bennée
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 28/35] target-arm: emulate LL/SC using cmpxchg helpers Richard Henderson
2016-10-05 13:40   ` Alex Bennée
2016-10-05 17:41     ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 29/35] target-arm: emulate SWP with atomic_xchg helper Richard Henderson
2016-10-05 13:35   ` Alex Bennée
2016-10-05 17:44     ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 30/35] target-arm: emulate aarch64's LL/SC using cmpxchg helpers Richard Henderson
2016-09-17  0:16   ` Emilio G. Cota
2016-09-17  0:40     ` Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 31/35] linux-user: remove handling of ARM's EXCP_STREX Richard Henderson
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 32/35] linux-user: remove handling of aarch64's EXCP_STREX Richard Henderson
2016-09-16 17:46 ` Richard Henderson [this message]
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 34/35] target-alpha: Introduce MMU_PHYS_IDX Richard Henderson
2016-10-05  0:11   ` Emilio G. Cota
2016-09-16 17:46 ` [Qemu-devel] [PATCH v4 35/35] target-alpha: Emulate LL/SC using cmpxchg helpers Richard Henderson
2016-10-05  0:11   ` Emilio G. Cota
2016-10-03 19:19 ` [Qemu-devel] [PATCH v4 00/35] cmpxchg-based emulation of atomics Alex Bennée
2016-10-05 13:43 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474048017-26696-34-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.