All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL v2 2/8] 9pfs: drop duplicate line in proxy backend
Date: Fri, 16 Sep 2016 20:03:24 +0200	[thread overview]
Message-ID: <1474049010-13533-3-git-send-email-groug@kaod.org> (raw)
In-Reply-To: <1474049010-13533-1-git-send-email-groug@kaod.org>

This double free did not cause harm because v9fs_string_free() sets
str->data to NULL and g_free(NULL) is valid.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
---
 hw/9pfs/9p-proxy.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
index 52bbf4f1b37c..d091564b6fd2 100644
--- a/hw/9pfs/9p-proxy.c
+++ b/hw/9pfs/9p-proxy.c
@@ -777,7 +777,6 @@ static int proxy_mkdir(FsContext *fs_ctx, V9fsPath *dir_path,
         errno = -retval;
         retval = -1;
     }
-    v9fs_string_free(&fullname);
     return retval;
 }
 
-- 
2.5.5

  parent reply	other threads:[~2016-09-16 18:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 18:03 [Qemu-devel] [PULL v2 0/8] 9p patches for 2.8 20160916 Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 1/8] 9pfs: drop unused fmt strings in the proxy backend Greg Kurz
2016-09-16 18:03 ` Greg Kurz [this message]
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 3/8] 9pfs: drop useless v9fs_string_null() function Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 4/8] 9pfs: introduce v9fs_path_sprintf() helper Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 5/8] tests: virtio-9p: introduce start/stop functions Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 6/8] tests: virtio-9p: add basic configuration test Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 7/8] tests: virtio-9p: add basic transaction test Greg Kurz
2016-09-19  9:41   ` Greg Kurz
2016-09-16 18:03 ` [Qemu-devel] [PULL v2 8/8] 9pfs: fix potential segfault during walk Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474049010-13533-3-git-send-email-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.