From: Andrew Jeffery <andrew@aj.id.au>
To: Timothy Pearson <tpearson@raptorengineering.com>,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH 03/17] Ensure that the old style MDIO interface is active before registering the MDIO bus on Faraday style MACs. Without this patch the hardware may continue to expect new style commands, yielding MDIO timeouts and general lack of communication with the MII.
Date: Mon, 19 Sep 2016 10:21:48 +0930 [thread overview]
Message-ID: <1474246308.13249.46.camel@aj.id.au> (raw)
In-Reply-To: <1474058133-27363-4-git-send-email-tpearson@raptorengineering.com>
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
It looks like your entire commit message went into the subject...
On Fri, 2016-09-16 at 15:35 -0500, Timothy Pearson wrote:
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 6 ++++++
> drivers/net/ethernet/faraday/ftgmac100.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index c20f767..778c625 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1250,6 +1250,7 @@ static int ftgmac100_setup_mdio(struct net_device *netdev)
> {
> struct ftgmac100 *priv = netdev_priv(netdev);
> struct platform_device *pdev = to_platform_device(priv->dev);
> + uint32_t revcr;
> int i, err = 0;
>
> /* initialize mdio bus */
> @@ -1257,6 +1258,11 @@ static int ftgmac100_setup_mdio(struct net_device *netdev)
> if (!priv->mii_bus)
> return -EIO;
>
> + /* This driver only supports the old MDIO interface -- enable it */
> + revcr = ioread32(priv->base + FTGMAC100_OFFSET_REVR);
> + revcr &= ~FTGMAC100_OFFSET_REVR_NEW_INTERFACE;
> + iowrite32(revcr, priv->base + FTGMAC100_OFFSET_REVR);
Did you have any thoughts on my comments from v1 for this change?
Cheers,
Andrew
> +
> priv->mii_bus->name = "ftgmac100_mdio";
> snprintf(priv->mii_bus->id, MII_BUS_ID_SIZE, "%s-%d",
> pdev->name, pdev->id);
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h
> index d07b6ea..ee5f758 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.h
> +++ b/drivers/net/ethernet/faraday/ftgmac100.h
> @@ -133,6 +133,8 @@
> #define FTGMAC100_DMAFIFOS_RXDMA_REQ (1 << 30)
> #define FTGMAC100_DMAFIFOS_TXDMA_REQ (1 << 31)
>
> +#define FTGMAC100_OFFSET_REVR_NEW_INTERFACE (1 << 31)
> +
> /*
> * Receive buffer size register
> */
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-19 0:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 20:35 [PATCH 00/17] Fix Firestone IPL failure Timothy Pearson
2016-09-16 20:35 ` [PATCH 01/17] phy/broadcom: Add support for the BCM54210E Timothy Pearson
2016-09-16 20:35 ` [PATCH 02/17] net/phy: Expose 100base-T capability only Timothy Pearson
2016-09-23 7:46 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 03/17] Ensure that the old style MDIO interface is active before registering the MDIO bus on Faraday style MACs. Without this patch the hardware may continue to expect new style commands, yielding MDIO timeouts and general lack of communication with the MII Timothy Pearson
2016-09-19 0:51 ` Andrew Jeffery [this message]
2016-09-19 17:02 ` Timothy Pearson
2016-09-19 23:47 ` Andrew Jeffery
2016-09-19 22:49 ` Timothy Pearson
2016-09-19 23:48 ` Andrew Jeffery
2016-09-16 20:35 ` [PATCH 04/17] Allow no-hw-checksum override in devicetree outside of NCSI mode Timothy Pearson
2016-09-23 6:57 ` Joel Stanley
2016-09-23 15:01 ` Timothy Pearson
2016-09-16 20:35 ` [PATCH 05/17] arm/dts: Remove mac hardware checksum from Firestone BMC Board Timothy Pearson
2016-09-16 20:35 ` [PATCH 06/17] mach-aspeed: Add missing Firestone setup method and call Timothy Pearson
2016-09-16 20:35 ` [PATCH 07/17] pinctrl-aspeed-g4: Add definition for GPIO pins J2 and O2 Timothy Pearson
2016-09-19 1:06 ` Andrew Jeffery
2016-10-10 6:53 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 08/17] pinctrl-aspeed-g4: Add missing MDIO1 pingroup Timothy Pearson
2016-09-19 1:01 ` Andrew Jeffery
2016-09-23 7:32 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 09/17] Add missing LEDs to Firestone DT Timothy Pearson
2016-09-16 20:35 ` [PATCH 10/17] Add missing console UART " Timothy Pearson
2016-09-23 7:15 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 11/17] Add missing UARTs " Timothy Pearson
2016-09-23 7:15 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 12/17] Fix Turismo I2C OCC mapping on Firestone Timothy Pearson
2016-09-16 20:35 ` [PATCH 13/17] Enable I2C hub and connected devices in Firestone DT Timothy Pearson
2016-09-23 7:17 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 14/17] Enable RGMII pin functions " Timothy Pearson
2016-09-19 1:00 ` Andrew Jeffery
2016-10-10 6:53 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 15/17] Enable vuart " Timothy Pearson
2016-09-23 7:18 ` Joel Stanley
2016-09-16 20:35 ` [PATCH 16/17] Add LED expander mapping to " Timothy Pearson
2016-09-23 7:42 ` Joel Stanley
2016-09-23 15:05 ` Timothy Pearson
2016-09-16 20:35 ` [PATCH 17/17] Enable FSI buffer on Firestone Timothy Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474246308.13249.46.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.