All of lore.kernel.org
 help / color / mirror / Atom feed
From: ville.syrjala@linux.intel.com
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 11/14] drm/rockchip: Fix sparse warnings
Date: Mon, 19 Sep 2016 16:33:52 +0300	[thread overview]
Message-ID: <1474292035-15695-12-git-send-email-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <1474292035-15695-1-git-send-email-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

drm/rockchip/rockchip_drm_drv.c:312:6: warning: symbol 'rockchip_drm_fb_suspend' was not declared. Should it be static?
drm/rockchip/rockchip_drm_drv.c:321:6: warning: symbol 'rockchip_drm_fb_resume' was not declared. Should it be static?
drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: symbol 'rockchip_drm_fbdev_init' was not declared. Should it be static?
drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: symbol 'rockchip_drm_fbdev_fini' was not declared. Should it be static?

Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   | 4 ++--
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 76eaf1de52e4..38c3be5f2c67 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -309,7 +309,7 @@ static struct drm_driver rockchip_drm_driver = {
 };
 
 #ifdef CONFIG_PM_SLEEP
-void rockchip_drm_fb_suspend(struct drm_device *drm)
+static void rockchip_drm_fb_suspend(struct drm_device *drm)
 {
 	struct rockchip_drm_private *priv = drm->dev_private;
 
@@ -318,7 +318,7 @@ void rockchip_drm_fb_suspend(struct drm_device *drm)
 	console_unlock();
 }
 
-void rockchip_drm_fb_resume(struct drm_device *drm)
+static void rockchip_drm_fb_resume(struct drm_device *drm)
 {
 	struct rockchip_drm_private *priv = drm->dev_private;
 
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index 207e01de6e32..a16c69f96ed5 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
@@ -20,6 +20,7 @@
 #include "rockchip_drm_drv.h"
 #include "rockchip_drm_gem.h"
 #include "rockchip_drm_fb.h"
+#include "rockchip_drm_fbdev.h"
 
 #define PREFERRED_BPP		32
 #define to_drm_private(x) \
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-09-19 13:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 13:33 [PATCH 00/14] drm: Fix a bunch of sparse warnings ville.syrjala
2016-09-19 13:33 ` [PATCH 01/14] drm/atomic-helper: Fix " ville.syrjala
2016-09-19 13:33 ` [PATCH 02/14] drm/blend: " ville.syrjala
2016-09-20  6:52   ` Laurent Pinchart
2016-09-19 13:33 ` [PATCH 03/14] drm/fb-helper: " ville.syrjala
2016-09-19 14:46   ` Daniel Vetter
2016-09-19 13:33 ` [PATCH 04/14] drm/arm: " ville.syrjala
2016-09-20  8:06   ` Liviu Dudau
2016-09-20 12:44     ` Liviu Dudau
2016-09-19 13:33 ` [PATCH 05/14] drm/ast: " ville.syrjala
2016-09-19 13:33 ` [PATCH 06/14] drm/bochs: " ville.syrjala
2016-09-19 13:33 ` [PATCH 07/14] drm/cirrus: " ville.syrjala
2016-09-19 13:33 ` [PATCH 08/14] drm/mgag200: " ville.syrjala
2016-09-19 13:33 ` [PATCH 09/14] drm/msm: " ville.syrjala
2016-09-19 13:52   ` Emil Velikov
2016-09-19 15:33     ` Jani Nikula
2016-09-19 16:01       ` Emil Velikov
2016-09-19 13:33 ` [PATCH 10/14] drm/nouveau: " ville.syrjala
2016-09-19 13:33 ` ville.syrjala [this message]
2016-09-19 13:33 ` [PATCH 12/14] drm/sti: " ville.syrjala
2016-09-19 14:52   ` Vincent ABRIOU
2016-09-19 13:33 ` [PATCH 13/14] drm/sun4i: " ville.syrjala
2016-09-19 19:54   ` Maxime Ripard
2016-09-19 13:33 ` [PATCH 14/14] drm/tilcdc: " ville.syrjala
2016-09-22 20:29   ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474292035-15695-12-git-send-email-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.