All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Fam Zheng <famz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/9] virtio: avoid exit() when device enters invalid states
Date: Tue, 20 Sep 2016 15:49:29 +0100	[thread overview]
Message-ID: <1474382978-26310-1-git-send-email-stefanha@redhat.com> (raw)

v4:
 * Rebase to qemu.git/master
 * Use "unsigned int" instead of "unsigned" in virtqueue_undo_map_desc() [Cornelia]

v3:
 * Patch 1: Fix typo and clarify commit description [Markus]
 * Use virtio_set_status() instead of open coding assignment [Cornelia]
 * Add live migration

v2:
 * Add VIRTIO_CONFIG_S_NEEDS_RESET notification for VIRTIO 1.0 [Cornelia]
   (Note I've sent a Linux virtio_config.h patch to get the constant added to
   the headers.)
 * Split int -> unsigned int change into separate commit [Fam]
 * Fix double "index" typo in commit description [Fam]

The virtio code calls exit() when the device enters an invalid state.  This
means invalid vring indices and descriptor chains kill the VM.  See the patch
descriptions for why this is a bad thing.

When the virtio device is in the broken state calls to virtqueue_pop() and
friends will pretend the virtqueue is empty.  This means the device will become
isolated from guest activity until it is reset again.

Stefan Hajnoczi (9):
  virtio: fix stray tab character
  virtio: stop virtqueue processing if device is broken
  virtio: migrate vdev->broken flag
  virtio: handle virtqueue_map_desc() errors
  virtio: handle virtqueue_get_avail_bytes() errors
  virtio: use unsigned int for virtqueue_get_avail_bytes() index
  virtio: handle virtqueue_read_next_desc() errors
  virtio: handle virtqueue_num_heads() errors
  virtio: handle virtqueue_get_head() errors

 hw/virtio/virtio.c         | 232 +++++++++++++++++++++++++++++++++++----------
 include/hw/virtio/virtio.h |   3 +
 2 files changed, 184 insertions(+), 51 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-09-20 14:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 14:49 Stefan Hajnoczi [this message]
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 1/9] virtio: fix stray tab character Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 2/9] virtio: stop virtqueue processing if device is broken Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 3/9] virtio: migrate vdev->broken flag Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 4/9] virtio: handle virtqueue_map_desc() errors Stefan Hajnoczi
2016-09-21  7:02   ` Greg Kurz
2016-09-21 11:15     ` Cornelia Huck
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 5/9] virtio: handle virtqueue_get_avail_bytes() errors Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 6/9] virtio: use unsigned int for virtqueue_get_avail_bytes() index Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 7/9] virtio: handle virtqueue_read_next_desc() errors Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 8/9] virtio: handle virtqueue_num_heads() errors Stefan Hajnoczi
2016-09-20 14:49 ` [Qemu-devel] [PATCH v4 9/9] virtio: handle virtqueue_get_head() errors Stefan Hajnoczi
2016-09-21 11:04 ` [Qemu-devel] [PATCH v4 0/9] virtio: avoid exit() when device enters invalid states Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474382978-26310-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.