From: Don Brace <don.brace@microsemi.com>
To: jejb@linux.vnet.ibm.com, john.hall@microsemi.com,
Kevin.Barnett@microsemi.com, Mahesh.Rajashekhara@microsemi.com,
hch@infradead.org, scott.teel@microsemi.com,
Viswas.G@microsemi.com, Justin.Lindley@microsemi.com,
scott.benesh@microsemi.com, elliott@hpe.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] hpsa: correct call to hpsa_do_reset
Date: Tue, 20 Sep 2016 15:42:30 -0500 [thread overview]
Message-ID: <147440415020.3922.8978668557368877094.stgit@brunhilda> (raw)
calling fill_cmd() using a MACRO definition not handled in
switch statement causes BUG() to be called.
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 2 +-
drivers/scsi/hpsa.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 030d002..94be51c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5935,7 +5935,7 @@ static int hpsa_send_reset_as_abort_ioaccel2(struct ctlr_info *h,
"Reset as abort: Resetting physical device at scsi3addr 0x%02x%02x%02x%02x%02x%02x%02x%02x\n",
psa[0], psa[1], psa[2], psa[3],
psa[4], psa[5], psa[6], psa[7]);
- rc = hpsa_do_reset(h, dev, psa, HPSA_RESET_TYPE_TARGET, reply_queue);
+ rc = hpsa_do_reset(h, dev, psa, HPSA_PHYS_TARGET_RESET, reply_queue);
if (rc != 0) {
dev_warn(&h->pdev->dev,
"Reset as abort: Failed on physical device at scsi3addr 0x%02x%02x%02x%02x%02x%02x%02x%02x\n",
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index a1487e6..82cdfad 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -312,7 +312,6 @@ struct offline_device_entry {
#define HPSA_DEVICE_RESET_MSG 1
#define HPSA_RESET_TYPE_CONTROLLER 0x00
#define HPSA_RESET_TYPE_BUS 0x01
-#define HPSA_RESET_TYPE_TARGET 0x03
#define HPSA_RESET_TYPE_LUN 0x04
#define HPSA_PHYS_TARGET_RESET 0x99 /* not defined by cciss spec */
#define HPSA_MSG_SEND_RETRY_LIMIT 10
next reply other threads:[~2016-09-20 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 20:42 Don Brace [this message]
2016-09-21 16:55 ` [PATCH] hpsa: correct call to hpsa_do_reset Tomas Henzl
2016-09-21 21:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147440415020.3922.8978668557368877094.stgit@brunhilda \
--to=don.brace@microsemi.com \
--cc=Justin.Lindley@microsemi.com \
--cc=Kevin.Barnett@microsemi.com \
--cc=Mahesh.Rajashekhara@microsemi.com \
--cc=Viswas.G@microsemi.com \
--cc=elliott@hpe.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.hall@microsemi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.benesh@microsemi.com \
--cc=scott.teel@microsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.