From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmZ8H-0002IB-7q for qemu-devel@nongnu.org; Wed, 21 Sep 2016 00:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmZ8E-0002PQ-WC for qemu-devel@nongnu.org; Wed, 21 Sep 2016 00:27:40 -0400 From: Fam Zheng Date: Wed, 21 Sep 2016 12:27:13 +0800 Message-Id: <1474432046-325-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v9 00/13] UUID clean ups for 2.8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, eblake@redhat.com, rth@twiddle.net v9: Add .gitignore patch. [Eric] Add Jeff's and Eric's r-b in other patches. The facts how we use libuuid now are not particularly pleasant. - VHDX driver depends on uuid, but is unconditionally checked in iotests 109. If it is not built, the test would fail, leaving no hint about that. In fact this even makes the feature implementation a bit ugly because it compromises the write protection on block 0 with image probing, silently. - A few other libuuid users, in block/ and crypto/, use it as an optional dependency, and compromises certain functionalities if it is not available. - On the other hand, there are already a few uuid function fallbacks in those callers, as well as some duplicated sscanf, snprintf and g_strdup_printf around UUID_FMT, which can be replaced with UUID parse/unparse routines. So instead of making libuuid a hard requirement, let's simply move the fallbacks to util and implement the random version of uuid generation, and be done with it. Fam Fam Zheng (13): util: Add UUID API uuid: Make null_uuid static vhdx: Use QEMU UUID API vdi: Use QEMU UUID API vpc: Use QEMU UUID API crypto: Switch to QEMU UUID API tests: No longer dependent on CONFIG_UUID configure: Remove detection code for UUID vl: Switch qemu_uuid to QemuUUID uuid: Tighten uuid parse tests: Add uuid tests Add UUID files to MAINTAINERS tests: Ignore test-uuid MAINTAINERS | 6 ++ arch_init.c | 19 ----- block/Makefile.objs | 2 +- block/iscsi.c | 2 +- block/vdi.c | 73 +++++-------------- block/vhdx-endian.c | 3 - block/vhdx.c | 9 +-- block/vpc.c | 10 +-- configure | 70 ++---------------- crypto/block-luks.c | 26 ++----- hw/ipmi/ipmi_bmc_sim.c | 2 +- hw/nvram/fw_cfg.c | 2 +- hw/ppc/spapr.c | 7 +- hw/ppc/spapr_rtas.c | 3 +- hw/smbios/smbios.c | 13 ++-- hw/xenpv/xen_domainbuild.c | 6 +- include/qemu/uuid.h | 59 +++++++++++++++ include/sysemu/sysemu.h | 7 +- qmp.c | 11 +-- stubs/uuid.c | 2 +- tests/.gitignore | 1 + tests/Makefile.include | 2 + tests/test-crypto-block.c | 2 +- tests/test-uuid.c | 177 +++++++++++++++++++++++++++++++++++++++++++++ ui/spice-core.c | 2 +- util/Makefile.objs | 1 + util/uuid.c | 114 +++++++++++++++++++++++++++++ vl.c | 7 +- 28 files changed, 425 insertions(+), 213 deletions(-) create mode 100644 include/qemu/uuid.h create mode 100644 tests/test-uuid.c create mode 100644 util/uuid.c -- 2.7.4