From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnKyy-0005of-F4 for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnKyu-0005om-9M for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:33:15 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnKyu-0005og-3Z for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:33:12 -0400 Received: by mail-wm0-f67.google.com with SMTP id l132so1282211wmf.1 for ; Fri, 23 Sep 2016 00:33:11 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 23 Sep 2016 09:31:45 +0200 Message-Id: <1474615909-17069-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1474615909-17069-1-git-send-email-pbonzini@redhat.com> References: <1474615909-17069-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 12/16] cpus-common: remove redundant call to exclusive_idle() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cota@braap.org, sergey.fedorov@linaro.org, alex.bennee@linaro.org, serge.fdrv@gmail.com No need to call exclusive_idle() from cpu_exec_end since it is done immediately afterwards in cpu_exec_start. Any exclusive section could run as soon as cpu_exec_end leaves, because cpu->running is false and the mutex is not taken, so the call does not add any protection either. Signed-off-by: Paolo Bonzini --- cpus-common.c | 1 - docs/tcg-exclusive.promela | 1 - 2 files changed, 2 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index 115f3d4..80aaf9b 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -221,7 +221,6 @@ void cpu_exec_end(CPUState *cpu) qemu_cond_signal(&exclusive_cond); } } - exclusive_idle(); qemu_mutex_unlock(&qemu_cpu_list_lock); } diff --git a/docs/tcg-exclusive.promela b/docs/tcg-exclusive.promela index 360edcd..9e7d9e3 100644 --- a/docs/tcg-exclusive.promela +++ b/docs/tcg-exclusive.promela @@ -123,7 +123,6 @@ byte has_waiter[N_CPUS]; } \ :: else -> skip; \ fi; \ - exclusive_idle(); \ MUTEX_UNLOCK(mutex); // Promela processes -- 2.7.4