All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Lyude Paul <thatslyude@gmail.com>,
	Andrew Duggan <aduggan@synaptics.com>,
	Christopher Heiny <cheiny@synaptics.com>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH v2 11/12] Input: synaptics-rmi4 - smbus: on resume, try 3 times if init fails
Date: Wed, 28 Sep 2016 10:35:46 +0200	[thread overview]
Message-ID: <1475051747-25988-12-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1475051747-25988-1-git-send-email-benjamin.tissoires@redhat.com>

In some rare cases, we can't retrieve the SMBus version and so we fail
binding the touchpad back. Instead of leaving a touchpad dead, try again
to reinitialize it.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

---

no changes in v2
---
 drivers/input/rmi4/rmi_smbus.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
index 023dbd5..a8e4af6 100644
--- a/drivers/input/rmi4/rmi_smbus.c
+++ b/drivers/input/rmi4/rmi_smbus.c
@@ -265,10 +265,29 @@ static int rmi_smb_reset(struct rmi_transport_dev *xport, u16 reset_addr)
 {
 	struct rmi_smb_xport *rmi_smb =
 		container_of(xport, struct rmi_smb_xport, xport);
+	struct i2c_client *client = rmi_smb->client;
+	struct rmi_device_platform_data *pdata;
+	int tries, ret;
 
 	rmi_smb_clear_state(rmi_smb);
 
-	return rmi_smb_enable_smbus_mode(rmi_smb);
+	for (tries = 3; tries > 0; tries--) {
+		ret = rmi_smb_enable_smbus_mode(rmi_smb);
+		if (!ret)
+			break;
+
+		/* we failed enabling SMBus, try again later */
+		msleep(500);
+	}
+
+	if (ret < 0) {
+		dev_warn(&client->dev,
+			 "failed to enable SMBus mode, giving up.\n");
+		pdata = dev_get_platdata(&rmi_smb->client->dev);
+		rmi_transport_enable(pdata, false);
+	}
+
+	return ret;
 }
 
 static const struct rmi_transport_ops rmi_smb_ops = {
-- 
2.7.4

  parent reply	other threads:[~2016-09-28  8:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  8:35 [PATCH v2 00/12] Synaptics RMI4 over SMBus Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 01/12] Input: synaptics-rmi4 - add SMBus support Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 02/12] Input: serio - store the pt_buttons in the struct serio directly Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 03/12] Input: synaptics-rmi4 - have only one struct platform data Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 04/12] Input: synaptics-rmi4 - add support for F03 Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 05/12] Input: synaptics-rmi4 - f03: grab data passed by transport device Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 06/12] Input: synaptics-rmi4 - Add rmi_find_function() Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 07/12] Input: synaptics-rmi4 - f30/f03: Forward mechanical buttons on buttonpads to PS/2 guest Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 08/12] Input: synaptics - allocate a Synaptics Intertouch device Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 09/12] Input: synaptics-rmi4 - add rmi_platform Benjamin Tissoires
2016-09-28  8:35 ` [PATCH v2 10/12] Input: synaptics-rmi4 - smbus: call psmouse_deactivate before binding/resume Benjamin Tissoires
2016-09-28  8:35 ` Benjamin Tissoires [this message]
2016-09-28  8:35 ` [PATCH v2 12/12] Input: synaptics-rmi4 - fix documentation of rmi_2d_sensor_platform_data Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475051747-25988-12-git-send-email-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=aduggan@synaptics.com \
    --cc=cheiny@synaptics.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=thatslyude@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.