From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56406 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbcI1Ihy (ORCPT ); Wed, 28 Sep 2016 04:37:54 -0400 Subject: Patch "hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common()" has been added to the 4.4-stable tree To: dan.carpenter@oracle.com, gregkh@linuxfoundation.org, richard@nod.at Cc: , From: Date: Wed, 28 Sep 2016 10:37:55 +0200 Message-ID: <1475051875438@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: hostfs-freeing-an-err_ptr-in-hostfs_fill_sb_common.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 8a545f185145e3c09348cd74326268ecfc6715a3 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 13 Jul 2016 13:12:34 +0300 Subject: hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common() From: Dan Carpenter commit 8a545f185145e3c09348cd74326268ecfc6715a3 upstream. We can't pass error pointers to kfree() or it causes an oops. Fixes: 52b209f7b848 ('get rid of hostfs_read_inode()') Signed-off-by: Dan Carpenter Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- fs/hostfs/hostfs_kern.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -959,10 +959,11 @@ static int hostfs_fill_sb_common(struct if (S_ISLNK(root_inode->i_mode)) { char *name = follow_link(host_root_path); - if (IS_ERR(name)) + if (IS_ERR(name)) { err = PTR_ERR(name); - else - err = read_name(root_inode, name); + goto out_put; + } + err = read_name(root_inode, name); kfree(name); if (err) goto out_put; Patches currently in stable-queue which might be from dan.carpenter@oracle.com are queue-4.4/mtd-pmcmsp-flash-allocating-too-much-in-init_msp_flash.patch queue-4.4/hostfs-freeing-an-err_ptr-in-hostfs_fill_sb_common.patch queue-4.4/mtd-maps-sa1100-flash-potential-null-dereference.patch queue-4.4/qxl-check-for-kmap-failures.patch queue-4.4/power-supply-max17042_battery-fix-model-download-bug.patch