From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Tvrtko Ursulin <tvrtko@ursulin.net>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client
Date: Wed, 28 Sep 2016 16:25:43 +0300 [thread overview]
Message-ID: <1475069143.2770.1.camel@linux.intel.com> (raw)
In-Reply-To: <1474969444-6640-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On ti, 2016-09-27 at 10:44 +0100, Tvrtko Ursulin wrote:
> -int i915_gem_request_add_to_client(struct drm_i915_gem_request *req,
> - struct drm_file *file)
> +void i915_gem_request_add_to_client(struct drm_i915_gem_request *req,
> + struct drm_file *file)
> {
> - struct drm_i915_private *dev_private;
> struct drm_i915_file_private *file_priv;
>
> - WARN_ON(!req || !file || req->file_priv);
> + GEM_BUG_ON(!req || !file || req->file_priv);
>
I might be inclined to drop this completely, we're going to OOPS
anwyway if one of those is null.
Anyway;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-28 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:44 [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client Tvrtko Ursulin
2016-09-28 8:49 ` ✗ Fi.CI.BAT: warning for drm/i915: Cleanup i915_gem_request_add_to_client (rev2) Patchwork
2016-09-28 11:12 ` ✗ Fi.CI.BAT: failure " Patchwork
2016-09-28 13:25 ` Joonas Lahtinen [this message]
2016-09-27 12:07 [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client Tvrtko Ursulin
2016-09-27 12:19 ` Chris Wilson
2016-09-27 12:35 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475069143.2770.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.