From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 10/24] xen: tracing: improve Credit2's
 tickle_check and burn_credits records
Date: Thu, 29 Sep 2016 19:23:51 +0200
Message-ID: <1475169831.5315.47.camel@citrix.com>
References: <147145358844.25877.7490417583264534196.stgit@Solace.fritz.box>
 <147145432341.25877.7540974364706702.stgit@Solace.fritz.box>
 <103f3792-922f-4386-4580-03027b4cff48@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0011031014594676497=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=073073991=dario.faggioli@citrix.com>)
 id 1bpf3w-0002oH-3S
 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2016 17:24:00 +0000
In-Reply-To: <103f3792-922f-4386-4580-03027b4cff48@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============0011031014594676497==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-NY+8fvlfceU+Uf2Gbyyo"

--=-NY+8fvlfceU+Uf2Gbyyo
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-09-20 at 15:35 +0100, George Dunlap wrote:
> On 17/08/16 18:18, Dario Faggioli wrote:
> >=20
> > In both Credit2's trace records relative to checking
> > whether we want to preempt a vcpu (in runq_tickle()),
> > and to credits being burn, make it explicit on which
> > pcpu the vcpu being considered is running.
> >=20
> > Such information isn't currently available, not even
> > by looking at on which pcpu the events happen, as we
> > do both the above operation from a certain pcpu on
> > vcpus running on different pcpus.
>=20
> But you should be able to tell where a given vcpu is currently
> running
> from the runstate changes, right?=C2=A0=C2=A0Obviously xentrace_format co=
uldn't
> tell you that, but xenalyze should be able to, unless there were lost
> trace records on the vcpu in question.
>=20
Well, yes and no. For instance, burn_credits() is not only called from
csched_schedule(), where indeed we have the information in close
records. It's also called from inside runq_tickle() itself (as we want
to update the credits of the various vcpus we are considering
preempting), which in turns can be called during vcpu wakeup.

In that case, knowing where a certain vcpu that we're asking to burn
its credit is running, may mean going quite a bit up in the trace, to
find its last context switch/runstate change, which is not always the
easiest thing to do.

It indeed can be scripted, but when _looking_ at a trace, trying to
figure out why you're observing this or that weird behavior, I think
knowing v->processor is a useful information.

> My modus operandi has been "try to keep trace volume from growing"
> rather than "wait until trace volume is noticably an issue and reduce
> it".=C2=A0=C2=A0Presumably you've been doing a lot of tracing -- do you t=
hink I
> should change my approach?
>=20
No, I think the approach is a good one. It's just that, in this case, I
think this is useful information, so I'll keep the patch in v2. But if
you're not sure, just ignore it, and we can sort this at another time.
:-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-NY+8fvlfceU+Uf2Gbyyo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJX7U4oAAoJEBZCeImluHPuiUwP/jGJru0XIZtTp5S/Qmgeqihx
TEHbcbnAgKDUw2jtlX/V0aMKZiSLlyjtaEpk13hRAB+tBVeOEccE+xI+0s2QSj+E
Q8rYK24W7Em8PpWU+1n3DCopTCjv1M9Vla3htawKQ4HWqNj3enRm2ZP8A45BB9hL
NOeRGnlZiaxvSZYWZbQB8hoosuC0PB8L5/EajPgsIheOtURR/cdw13NS54F6AoPy
Krzla6AUf8R+TZ7Rrrg46B7yDs3uqgwNrOncsZmxQjNwmU9n9uppnRdV08/lMEhm
u9ClM5QEeMCwAJcOH8tNpGUfSjBW6bQtOHrfOr4E4toSqREKf06aachc5gDNt8OF
PUYUxLP4DoHprLbzSqGnss4pcfyiNyZO3XVjHom6EMBnZKfDu3UBK9BGvF7ZfzS8
68ZwOHYU7h0IkZRN1dwPi+rvZv3ZEPRnT10G7ORHhQbwExK5U0DHjTOEAsC2pIxy
sx/J9LOFC1CoTuNwzGefM/0EnmeTQefNvMkvCyyghUHLsLBbZRzMiGrZwoj86xFd
Uz7FRL8z4xdPIs+AAlHogb4c/Uyskad+EReamgjIfv/nDhCCItLJ92rGXTySe6Ox
JJur0/1lNio9nWMT5PMtv++dEJY8CUevGmfqBpHUrU6Ek95y4NmZXeZIsX5YHLu0
V8xhTjO/zLjLOrS4QQDa
=k5Do
-----END PGP SIGNATURE-----

--=-NY+8fvlfceU+Uf2Gbyyo--


--===============0011031014594676497==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============0011031014594676497==--