From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 10/24] xen: tracing: improve Credit2's tickle_check and burn_credits records Date: Thu, 29 Sep 2016 22:53:52 +0200 Message-ID: <1475182432.5315.50.camel@citrix.com> References: <147145358844.25877.7490417583264534196.stgit@Solace.fritz.box> <147145432341.25877.7540974364706702.stgit@Solace.fritz.box> <103f3792-922f-4386-4580-03027b4cff48@citrix.com> <1475169831.5315.47.camel@citrix.com> <009c1d23-81ea-8d0b-5e65-d33d32cb3304@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3500777410551516622==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpiLA-0000F9-6x for xen-devel@lists.xenproject.org; Thu, 29 Sep 2016 20:54:00 +0000 In-Reply-To: <009c1d23-81ea-8d0b-5e65-d33d32cb3304@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: George Dunlap , Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============3500777410551516622== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-efcY3QHbG860wiWhZIU7" --=-efcY3QHbG860wiWhZIU7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-09-29 at 18:28 +0100, George Dunlap wrote: > On 29/09/16 18:23, Dario Faggioli wrote: > > In that case, knowing where a certain vcpu that we're asking to > > burn > > its credit is running, may mean going quite a bit up in the trace, > > to > > find its last context switch/runstate change, which is not always > > the > > easiest thing to do. > >=20 > > It indeed can be scripted, but when _looking_ at a trace, trying to > > figure out why you're observing this or that weird behavior, I > > think > > knowing v->processor is a useful information. >=20 > But if you're using xenalyze, xenalyze will know where the vcpu is > running / was last run; couldn't you have xenalyze report that > information when dumping the burn_credits record? >=20 Yes, this is indeed a possibility. Xenalyze is not doing anything like or similar to that for now (at least, not in dump mode), that's probably why it did not occur to me that this could be done. But yeah, we've already discussed that it can become more intelligent and do more complex things and more refined reports, and this can well fit into that. > Again, I'm just pushing back to make sure the additional trace volume > is > actually necessary. :-) >=20 Sure, that's fine! Ok, let's drop this patch for now then. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-efcY3QHbG860wiWhZIU7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX7X9gAAoJEBZCeImluHPumiUP/i/QlwtO3rH7CxRrtbiGfS9M 9g3n9PGKoEEyLF5pYjefeD1JRXT+u4jev+72eBUeZ5RV6EvPOWHUl2Cx0hnaS8zg SI5bcRPF4ZCtFKN4KIaEiJ3MpPEnW5O3HO4g02BJaz2Z9PlJFPNzXf3/15mDPZpP eEM/eJeMY5YRcuNhArg9O/zzZKmWbeYxBPl7Co+coIeQ2WKl0mRmvqKtXzCHazDq m2/ACuIgkWXKXOosVYgo0QJANWgO9zO0HJ27S6nB32Z9X9ql8xWvMOGXDumX60bg 13kpXL3t7xCUnnjTTlxqbqUfHfHGp1EQGnHJMM6BSEAfNF52pOn7k+ywoGqR1Kso O0LGAffDlvDDuSLUdQnUfeavDhbEsFYI0+EjgPXJIfqgQ2++QvfnxIa3zsxhuMZ4 Y5TtGV2ZMCxmJT76Wi2LTtG5dD7R+cSVZW3O84L4ykjo6ABYbf3S4RUmhKbCqzqM wXIISJ+INot7fqad6nX+YqpN3n5GKXsoj+qivGW317acOnULaNqt74z1WAPQS1O+ d93+3UhFPq7SZiL/PW8xRYpF76ZqJnAXcThJb+IlOr87PjtwLfHIwZruWGh5zyS3 qFTNvC86ihb+rMtCOdycrDTYlfwcj5WBo4Y7OqpcihMIIRz5lAa6/o8u3WRgIzX5 mBOhjBc3HOJ8UahaGkpk =aLBf -----END PGP SIGNATURE----- --=-efcY3QHbG860wiWhZIU7-- --===============3500777410551516622== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============3500777410551516622==--