From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brTqQ-0003d8-1R for qemu-devel@nongnu.org; Tue, 04 Oct 2016 13:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brTqM-0000Be-Hx for qemu-devel@nongnu.org; Tue, 04 Oct 2016 13:49:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brTqM-0000BS-CA for qemu-devel@nongnu.org; Tue, 04 Oct 2016 13:49:30 -0400 From: "Dr. David Alan Gilbert (git)" Date: Tue, 4 Oct 2016 18:49:27 +0100 Message-Id: <1475603367-4054-2-git-send-email-dgilbert@redhat.com> In-Reply-To: <1475603367-4054-1-git-send-email-dgilbert@redhat.com> References: <1475603367-4054-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PULL 1/1] hmp: fix qemu crash due to ioapic state dump w/ split irqchip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org From: Wanpeng Li The qemu will crash when info ioapic through hmp if irqchip is split. Below message is splat: KVM_GET_IRQCHIP failed: Unknown error -6 This patch fix it by dumping the ioapic state from the qemu emulated ioapic if irqchip is split. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Wanpeng Li Message-Id: <1474602456-3232-1-git-send-email-wanpeng.li@hotmail.com> Reviewed-by: Peter Xu Message-ID: <20160923090824.GF15411@pxdev.xzpeter.org> Signed-off-by: Dr. David Alan Gilbert --- target-i386/monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/monitor.c b/target-i386/monitor.c index fccfe40..9a3b4d7 100644 --- a/target-i386/monitor.c +++ b/target-i386/monitor.c @@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict) void hmp_info_io_apic(Monitor *mon, const QDict *qdict) { - if (kvm_irqchip_in_kernel()) { + if (kvm_irqchip_in_kernel() && + !kvm_irqchip_is_split()) { kvm_ioapic_dump_state(mon, qdict); } else { ioapic_dump_state(mon, qdict); -- 2.7.4