All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Subject: [RFC 4/5] smiapp: Support ACPI power control
Date: Wed,  5 Oct 2016 10:21:48 +0300	[thread overview]
Message-ID: <1475652109-22164-5-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1475652109-22164-1-git-send-email-sakari.ailus@linux.intel.com>

On ACPI systems the ACPI will control at least regulators to the sensor. On
such systems the sensor driver does not explicitly need to control them,
thus make them optional.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 59872b3..e0d7586 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -2887,7 +2887,7 @@ static int smiapp_probe(struct i2c_client *client,
 	v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops);
 	sensor->src->sd.internal_ops = &smiapp_internal_src_ops;
 
-	sensor->vana = devm_regulator_get(&client->dev, "vana");
+	sensor->vana = devm_regulator_get_optional(&client->dev, "vana");
 	if (IS_ERR(sensor->vana)) {
 		dev_err(&client->dev, "could not get regulator for vana\n");
 		return PTR_ERR(sensor->vana);
-- 
2.7.4


  parent reply	other threads:[~2016-10-05  7:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05  7:21 [RFC 0/5] V4L2 fwnode support Sakari Ailus
2016-10-05  7:21 ` [RFC 1/5] v4l: fwnode: Support generic fwnode instead of just OF Sakari Ailus
2016-10-05  7:21 ` [RFC 2/5] v4l: async: Match fwnode instead of of_node Sakari Ailus
2016-10-05  7:21 ` [RFC 3/5] omap3isp: Switch to fwnode API Sakari Ailus
2016-10-05  7:21 ` Sakari Ailus [this message]
2016-10-05  7:21 ` [RFC 5/5] smiapp: " Sakari Ailus
2016-10-05  8:32 ` [RFC 6/6] v4l2: async: Provide interoperability between OF and fwnode matching Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475652109-22164-5-git-send-email-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.