From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsQi5-0003UV-HN for qemu-devel@nongnu.org; Fri, 07 Oct 2016 04:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsQi0-0003Np-SI for qemu-devel@nongnu.org; Fri, 07 Oct 2016 04:40:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsQi0-0003Ni-Ko for qemu-devel@nongnu.org; Fri, 07 Oct 2016 04:40:48 -0400 Message-ID: <1475829645.13132.20.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 07 Oct 2016 10:40:45 +0200 In-Reply-To: <20161006234912.GF18490@umbus.fritz.box> References: <1475765448-18949-1-git-send-email-lvivier@redhat.com> <20161006234912.GF18490@umbus.fritz.box> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Laurent Vivier , qemu-devel@nongnu.org, Thomas Huth On Fr, 2016-10-07 at 10:49 +1100, David Gibson wrote: > On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote: > > Two minor cleanups: > > - exit gracefully in case on unsupported target, > > - put machine command line in a constant to avoid > > to duplicate it. > >=20 > > Signed-off-by: Laurent Vivier >=20 > Reviewed-by: David Gibson >=20 > I'm not sure if I should take this through my tree or not. Feel free to do so, makes sense to merge this together with the ppc usb test patches. Avoids conflicts. Reviewed-by: Gerd Hoffmann But I can take it through the usb tree too, I have some pending stuff and will probably prepare a pull request early next week. cheers, Gerd