From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932873AbcJHAMZ (ORCPT ); Fri, 7 Oct 2016 20:12:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32920 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbcJHAMT (ORCPT ); Fri, 7 Oct 2016 20:12:19 -0400 From: Lyude To: intel-gfx@lists.freedesktop.org Cc: Lyude , Daniel Vetter , Jani Nikula , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 00/10] Start of skl watermark cleanup Date: Fri, 7 Oct 2016 20:11:24 -0400 Message-Id: <1475885497-6094-1-git-send-email-cpaul@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 08 Oct 2016 00:12:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While it (mostly) works, the code for handling watermarks on Skylake has been kind of ugly for a while. As well a lot of it isn't that friendly to atomic transactions, Lots of copy paste, redundant wm values, etc. While this isn't a full cleanup, it's a good start. As well, we add a couple of features for making debugging watermarks a little easier. Lyude (10): drm/i915/skl: Move per-pipe ddb allocations into crtc states drm/i915/skl: Remove linetime from skl_wm_values drm/i915/gen9: Make skl_wm_level per-plane drm/i915/gen9: Cleanup skl_pipe_wm_active_state drm/i915/gen9: Get rid of redundant watermark values drm/i915/gen9: Add ddb changes to atomic debug output drm/i915/gen9: Make skl_pipe_wm_get_hw_state() reusable drm/i915/gen9: Add skl_wm_level_equals() drm/i915/gen9: Actually verify WM levels in verify_wm_state() drm/i915/gen9: Don't wrap strings in verify_wm_state() drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/intel_display.c | 138 +++++++--- drivers/gpu/drm/i915/intel_drv.h | 24 +- drivers/gpu/drm/i915/intel_pm.c | 470 +++++++++++++++++------------------ drivers/gpu/drm/i915/intel_sprite.c | 8 +- 5 files changed, 357 insertions(+), 293 deletions(-) -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Subject: [PATCH v2 00/10] Start of skl watermark cleanup Date: Fri, 7 Oct 2016 20:11:24 -0400 Message-ID: <1475885497-6094-1-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: intel-gfx@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Lyude List-Id: dri-devel@lists.freedesktop.org V2hpbGUgaXQgKG1vc3RseSkgd29ya3MsIHRoZSBjb2RlIGZvciBoYW5kbGluZyB3YXRlcm1hcmtz IG9uIFNreWxha2UgaGFzIGJlZW4Ka2luZCBvZiB1Z2x5IGZvciBhIHdoaWxlLiBBcyB3ZWxsIGEg bG90IG9mIGl0IGlzbid0IHRoYXQgZnJpZW5kbHkgdG8gYXRvbWljCnRyYW5zYWN0aW9ucywgTG90 cyBvZiBjb3B5IHBhc3RlLCByZWR1bmRhbnQgd20gdmFsdWVzLCBldGMuIFdoaWxlIHRoaXMgaXNu J3QgYQpmdWxsIGNsZWFudXAsIGl0J3MgYSBnb29kIHN0YXJ0LiBBcyB3ZWxsLCB3ZSBhZGQgYSBj b3VwbGUgb2YgZmVhdHVyZXMgZm9yCm1ha2luZyBkZWJ1Z2dpbmcgd2F0ZXJtYXJrcyBhIGxpdHRs ZSBlYXNpZXIuCgpMeXVkZSAoMTApOgogIGRybS9pOTE1L3NrbDogTW92ZSBwZXItcGlwZSBkZGIg YWxsb2NhdGlvbnMgaW50byBjcnRjIHN0YXRlcwogIGRybS9pOTE1L3NrbDogUmVtb3ZlIGxpbmV0 aW1lIGZyb20gc2tsX3dtX3ZhbHVlcwogIGRybS9pOTE1L2dlbjk6IE1ha2Ugc2tsX3dtX2xldmVs IHBlci1wbGFuZQogIGRybS9pOTE1L2dlbjk6IENsZWFudXAgc2tsX3BpcGVfd21fYWN0aXZlX3N0 YXRlCiAgZHJtL2k5MTUvZ2VuOTogR2V0IHJpZCBvZiByZWR1bmRhbnQgd2F0ZXJtYXJrIHZhbHVl cwogIGRybS9pOTE1L2dlbjk6IEFkZCBkZGIgY2hhbmdlcyB0byBhdG9taWMgZGVidWcgb3V0cHV0 CiAgZHJtL2k5MTUvZ2VuOTogTWFrZSBza2xfcGlwZV93bV9nZXRfaHdfc3RhdGUoKSByZXVzYWJs ZQogIGRybS9pOTE1L2dlbjk6IEFkZCBza2xfd21fbGV2ZWxfZXF1YWxzKCkKICBkcm0vaTkxNS9n ZW45OiBBY3R1YWxseSB2ZXJpZnkgV00gbGV2ZWxzIGluIHZlcmlmeV93bV9zdGF0ZSgpCiAgZHJt L2k5MTUvZ2VuOTogRG9uJ3Qgd3JhcCBzdHJpbmdzIGluIHZlcmlmeV93bV9zdGF0ZSgpCgogZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgIHwgIDEwICstCiBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMzggKysrKysrKy0tLQogZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDI0ICstCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jICAgICAgfCA0NzAgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jICB8ICAgOCArLQogNSBmaWxlcyBjaGFu Z2VkLCAzNTcgaW5zZXJ0aW9ucygrKSwgMjkzIGRlbGV0aW9ucygtKQoKLS0gCjIuNy40CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK