All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Tsyrklevich <vlad@tsyrklevich.net>
To: kvm@vger.kernel.org
Cc: alex.williamson@redhat.com, Vlad Tsyrklevich <vlad@tsyrklevich.net>
Subject: [PATCH] vfio/pci: Fix integer overflow/heap memory disclosure
Date: Tue, 11 Oct 2016 13:02:19 +0200	[thread overview]
Message-ID: <1476183739-35210-1-git-send-email-vlad@tsyrklevich.net> (raw)

The VFIO_DEVICE_SET_IRQS and VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctls
do not sufficiently sanitize user-supplied integers, allowing users to
read arbitrary amounts of kernel heap memory or cause a crash.

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>

---
 drivers/vfio/pci/vfio_pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index d624a52..c3fbfb8 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -838,6 +838,7 @@ static long vfio_pci_ioctl(void *device_data,
 			return -EFAULT;
 
 		if (hdr.argsz < minsz || hdr.index >= VFIO_PCI_NUM_IRQS ||
+		    hdr.count >= (U32_MAX - hdr.start) ||
 		    hdr.flags & ~(VFIO_IRQ_SET_DATA_TYPE_MASK |
 				  VFIO_IRQ_SET_ACTION_TYPE_MASK))
 			return -EINVAL;
@@ -909,6 +910,9 @@ static long vfio_pci_ioctl(void *device_data,
 
 		WARN_ON(!fill.max); /* Should always be at least one */
 
+		if (hdr.count > fill.max)
+			hdr.count = fill.max;
+
 		/*
 		 * If there's enough space, fill it now, otherwise return
 		 * -ENOSPC and the number of devices affected.
-- 
2.7.0


             reply	other threads:[~2016-10-11 11:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 11:02 Vlad Tsyrklevich [this message]
2016-10-11 16:10 ` [PATCH] vfio/pci: Fix integer overflow/heap memory disclosure Alex Williamson
2016-10-11 20:04   ` Vlad Tsyrklevich
2016-10-11 22:39     ` Alex Williamson
2016-10-12  7:53       ` [PATCH v2] vfio/pci: Fix integer overflows, bitmask check Vlad Tsyrklevich
2016-10-12 14:51         ` Alex Williamson
2016-10-12 15:06           ` Vlad Tsyrklevich
2016-10-12 15:39             ` Alex Williamson
2016-10-12 16:51               ` [PATCH v3] " Vlad Tsyrklevich
2016-10-26 21:19                 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476183739-35210-1-git-send-email-vlad@tsyrklevich.net \
    --to=vlad@tsyrklevich.net \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.