From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 01/10] ui: remove misleading comment from vnc_init_state
Date: Thu, 13 Oct 2016 11:32:49 +0200 [thread overview]
Message-ID: <1476351178-32540-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1476351178-32540-1-git-send-email-kraxel@redhat.com>
From: "Daniel P. Berrange" <berrange@redhat.com>
The last line in vnc_init_state() says
/* vs might be free()ed here */
This was added in
commit 198a0039c5fca224a77e9761e2350dd9cc102ad0
Author: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue Jun 16 14:19:48 2009 +0200
vnc: rework VncState release workflow.
because the preceeding 'vnc_update_client()' could indeed
release the VncState instance.
The call to vnc_update_client() was removed not long after
though in
commit 1fc624122fb923c7fc4c1f426541d953e7df13c9
Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Date: Mon Aug 3 10:54:32 2009 +0100
single vnc server surface
and so the comment has been wrong ever since
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1475163940-26094-2-git-send-email-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 76a3273..5faf79b 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3092,8 +3092,6 @@ void vnc_init_state(VncState *vs)
vs->mouse_mode_notifier.notify = check_pointer_type_change;
qemu_add_mouse_mode_change_notifier(&vs->mouse_mode_notifier);
-
- /* vs might be free()ed here */
}
static gboolean vnc_listen_io(QIOChannel *ioc,
--
1.8.3.1
next prev parent reply other threads:[~2016-10-13 9:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 9:32 [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix Gerd Hoffmann
2016-10-13 9:32 ` Gerd Hoffmann [this message]
2016-10-13 9:32 ` [Qemu-devel] [PULL 02/10] ui: remove 'enabled' and 'ws_enabled' fields from VncState Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 03/10] ui: remove 'ws_tls' field " Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 04/10] ui: rename misleading 'VncDisplay' variables Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 05/10] ui: refactor method for setting up VncDisplay auth types Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 06/10] ui: remove bogus call to graphic_hw_update() in vnc_listen_io Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 07/10] ui: remove bogus call to reset_keys() in vnc_init_state Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 08/10] ui: move some initialization out of vnc_init_state Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 09/10] ui: rename vnc_init_state to vnc_start_protocol Gerd Hoffmann
2016-10-13 9:32 ` [Qemu-devel] [PULL 10/10] input-linux: initialize key state Gerd Hoffmann
2016-10-13 15:08 ` [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476351178-32540-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.