All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, joel@jms.id.au,
	Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: [PATCH net 1/5] net/ncsi: Not fetch active package and channel again
Date: Fri, 14 Oct 2016 13:53:30 +1100	[thread overview]
Message-ID: <1476413614-24586-2-git-send-email-gwshan@linux.vnet.ibm.com> (raw)
In-Reply-To: <1476413614-24586-1-git-send-email-gwshan@linux.vnet.ibm.com>

In ncsi_suspend_channel(), we fetch the active package and
channel to local variables for twice. It's unnecessary. This
drops one of them. No functional changes introduced.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
 net/ncsi/ncsi-manage.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
index 5e509e5..1bc96dc 100644
--- a/net/ncsi/ncsi-manage.c
+++ b/net/ncsi/ncsi-manage.c
@@ -545,8 +545,6 @@ static void ncsi_suspend_channel(struct ncsi_dev_priv *ndp)
 	case ncsi_dev_state_suspend_deselect:
 		ndp->pending_req_num = 1;
 
-		np = ndp->active_package;
-		nc = ndp->active_channel;
 		nca.package = np->id;
 		if (nd->state == ncsi_dev_state_suspend_select) {
 			nca.type = NCSI_PKT_CMD_SP;
-- 
2.1.0

  reply	other threads:[~2016-10-14  2:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14  2:53 [PATCH net 0/5] net/ncsi: More bug fixes Gavin Shan
2016-10-14  2:53 ` Gavin Shan [this message]
2016-10-14  2:53 ` [PATCH net 2/5] net/ncsi: Split out logic for ncsi_dev_state_suspend_select Gavin Shan
2016-10-14  6:02   ` Joel Stanley
2016-10-14 10:28     ` Gavin Shan
2016-10-14  2:53 ` [PATCH net 3/5] net/ncsi: Fix stale link state of inactive channels on failover Gavin Shan
2016-10-14  6:02   ` Joel Stanley
2016-10-14 10:37     ` Gavin Shan
2016-10-14  2:53 ` [PATCH net 4/5] net/ncsi: Choose hot channel as active one if necessary Gavin Shan
2016-10-14  6:02   ` Joel Stanley
2016-10-14 10:39     ` Gavin Shan
2016-10-14  2:53 ` [PATCH net 5/5] net/ncsi: Improve HNCDSC AEN handler Gavin Shan
2016-10-20  0:54 ` [PATCH net 0/5] net/ncsi: More bug fixes Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476413614-24586-2-git-send-email-gwshan@linux.vnet.ibm.com \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=joel@jms.id.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.