From: Christoph Hellwig <hch@lst.de> To: linux-xfs@vger.kernel.org Cc: michaelcallahan@fb.com Subject: [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents Date: Mon, 17 Oct 2016 22:22:31 +0200 [thread overview] Message-ID: <1476735753-5861-2-git-send-email-hch@lst.de> (raw) In-Reply-To: <1476735753-5861-1-git-send-email-hch@lst.de> If we have too many busy extents, or just enough to make our wanted allocation impossible we will never move on to another AG in xfs_alloc_vextent currently. Change the loop exit condition to keep looking for an AG if we can't allocate an extent. For the single AG cases we don't need to change anything as the higher layers need to handle this case. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/libxfs/xfs_alloc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c index effb64c..0a04bec 100644 --- a/fs/xfs/libxfs/xfs_alloc.c +++ b/fs/xfs/libxfs/xfs_alloc.c @@ -2753,13 +2753,18 @@ xfs_alloc_vextent( trace_xfs_alloc_vextent_nofix(args); goto error0; } + /* - * If we get a buffer back then the allocation will fly. + * If we get a buffer back then the allocation will fly, + * unless there are busy extents in the way. */ if (args->agbp) { - if ((error = xfs_alloc_ag_vextent(args))) + error = xfs_alloc_ag_vextent(args); + if (error) goto error0; - break; + if (args->agbno != NULLAGBLOCK) + break; + xfs_trans_brelse(args->tp, args->agbp); } trace_xfs_alloc_vextent_loopfailed(args); -- 2.1.4
next prev parent reply other threads:[~2016-10-17 20:22 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-17 20:22 discard improvements Christoph Hellwig 2016-10-17 20:22 ` Christoph Hellwig [this message] 2016-10-19 13:48 ` [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents Brian Foster 2016-10-21 12:48 ` Christoph Hellwig 2016-10-21 14:41 ` Brian Foster 2016-11-08 6:15 ` Dave Chinner 2016-11-10 19:17 ` Christoph Hellwig 2016-10-17 20:22 ` [PATCH 2/3] xfs: don't block the log commit handler for discards Christoph Hellwig 2016-10-17 23:29 ` Dave Chinner 2016-10-18 5:05 ` Christoph Hellwig 2016-10-19 10:58 ` Christoph Hellwig 2016-10-28 16:16 ` Michael Callahan 2016-10-31 15:16 ` Christoph Hellwig 2016-10-17 20:22 ` [PATCH 3/3] xfs: merge discard requests Christoph Hellwig 2016-10-28 10:11 ` discard improvements Avi Kivity 2016-10-31 15:14 ` Christoph Hellwig 2016-11-05 18:18 ` Avi Kivity 2016-11-06 16:36 ` Christoph Hellwig 2016-11-06 23:21 ` Dave Chinner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1476735753-5861-2-git-send-email-hch@lst.de \ --to=hch@lst.de \ --cc=linux-xfs@vger.kernel.org \ --cc=michaelcallahan@fb.com \ --subject='Re: [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.