From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933905AbcJRHQF (ORCPT ); Tue, 18 Oct 2016 03:16:05 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:52119 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933179AbcJRHOX (ORCPT ); Tue, 18 Oct 2016 03:14:23 -0400 From: Nobuhiro Iwamatsu To: Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck Cc: linux-kernel@vger.kernel.org, cti.systems-productivity-manager.ts@hitachi.com, Nobuhiro Iwamatsu , Hiraku Toyooka , Mark Salyzyn , Seiji Aguchi , Shuah Khan Subject: [PATCH v3 3/8] ramoops: Add __ramoops_init_prz() as generic function Date: Tue, 18 Oct 2016 16:13:29 +0900 Message-Id: <1476774814-6840-4-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> X-Mailer: git-send-email 2.8.1.windows.1 In-Reply-To: <1476774814-6840-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> References: <1476774814-6840-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This commit adds generic function __ramoops_init_prz() to reduce redundancy between ramoops_init_prz() and ramoops_init_przs(). Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Hiraku Toyooka Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: Shuah Khan Cc: Tony Luck V3: Rebase. Split patch. --- fs/pstore/ram.c | 69 ++++++++++++++++++++++++++++++--------------------------- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 691680f..4fe27fb 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -404,6 +404,38 @@ static void ramoops_free_przs(struct persistent_ram_zone **przs, int cnt) kfree(przs); } +static int __ramoops_init_prz(struct device *dev, struct ramoops_context *cxt, + struct persistent_ram_zone **prz, + phys_addr_t *paddr, size_t sz, u32 sig, bool zap) +{ + if (!sz) + return 0; + + if (*paddr + sz - cxt->phys_addr > cxt->size) { + dev_err(dev, "no room for mem region (0x%zx@0x%llx) in (0x%lx@0x%llx)\n", + sz, (unsigned long long)*paddr, + cxt->size, (unsigned long long)cxt->phys_addr); + return -ENOMEM; + } + + *prz = persistent_ram_new(*paddr, sz, sig, &cxt->ecc_info, + cxt->memtype); + if (IS_ERR(*prz)) { + int err = PTR_ERR(*prz); + + dev_err(dev, "failed to request mem region (0x%zx@0x%llx): %d\n", + sz, (unsigned long long)*paddr, err); + return err; + } + + if (zap) + persistent_ram_zap(*prz); + + *paddr += sz; + + return 0; +} + static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt, phys_addr_t *paddr, size_t dump_mem_sz) { @@ -430,21 +462,15 @@ static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt, } for (i = 0; i < cxt->max_dump_cnt; i++) { - cxt->przs[i] = persistent_ram_new(*paddr, cxt->record_size, 0, - &cxt->ecc_info, - cxt->memtype); - if (IS_ERR(cxt->przs[i])) { - err = PTR_ERR(cxt->przs[i]); - dev_err(dev, "failed to request mem region (0x%zx@0x%llx): %d\n", - cxt->record_size, (unsigned long long)*paddr, err); - + err = __ramoops_init_prz(dev, cxt, &cxt->przs[i], paddr, + cxt->record_size, 0, false); + if (err) { while (i > 0) { i--; persistent_ram_free(cxt->przs[i]); } goto fail_prz; } - *paddr += cxt->record_size; } return 0; @@ -459,30 +485,7 @@ static int ramoops_init_prz(struct device *dev, struct ramoops_context *cxt, struct persistent_ram_zone **prz, phys_addr_t *paddr, size_t sz, u32 sig) { - if (!sz) - return 0; - - if (*paddr + sz - cxt->phys_addr > cxt->size) { - dev_err(dev, "no room for mem region (0x%zx@0x%llx) in (0x%lx@0x%llx)\n", - sz, (unsigned long long)*paddr, - cxt->size, (unsigned long long)cxt->phys_addr); - return -ENOMEM; - } - - *prz = persistent_ram_new(*paddr, sz, sig, &cxt->ecc_info, cxt->memtype); - if (IS_ERR(*prz)) { - int err = PTR_ERR(*prz); - - dev_err(dev, "failed to request mem region (0x%zx@0x%llx): %d\n", - sz, (unsigned long long)*paddr, err); - return err; - } - - persistent_ram_zap(*prz); - - *paddr += sz; - - return 0; + return __ramoops_init_prz(dev, cxt, prz, paddr, sz, sig, true); } static int ramoops_parse_dt_size(struct platform_device *pdev, -- 2.9.3