All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org
Subject: clean up block ops defintions
Date: Thu, 20 Oct 2016 15:12:08 +0200	[thread overview]
Message-ID: <1476969135-32732-1-git-send-email-hch@lst.de> (raw)

Hi Jens,

this series takes advantage of the the new REQ_OP* scheme to further
clean up the way how we classify bios and requests.

After the series both the bio and request have a field where the
REQ_OP operation is stored in directly without any shiting around,
and the coomon REQ_* flags can be ORed into directly as well.  All
the bio flags are now in the existing bi_flags field, and the many
request-only flags are moved into a new field in struct request,
which is split off cmd_flags.

Last but not least this series ensures that we can encode the
operational direction of a command in it's code.  Currently the
op_is_write, bio_data_dir and rq_data_dir helpers all assume that
everything but a READ is a data out command.  This surprisingly
actually was true until this week, but the new shingled driver
support conflicts with it - it's just that the relevant path
didn't use any of these helpers so that issue wasn't noticed.

             reply	other threads:[~2016-10-20 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 13:12 Christoph Hellwig [this message]
2016-10-20 13:12 ` [PATCH 1/7] block: remove bio_is_rw Christoph Hellwig
2016-10-20 13:12 ` [PATCH 2/7] block: REQ_NOMERGE is common to the bio and request Christoph Hellwig
2016-10-20 13:12 ` [PATCH 3/7] block: move REQ_RAHEAD to common flags Christoph Hellwig
2016-10-20 13:12 ` [PATCH 4/7] block: replace REQ_THROTTLED with a bio flag Christoph Hellwig
2016-10-20 13:12 ` [PATCH 5/7] block: split out request-only flags into a new namespace Christoph Hellwig
2016-10-20 13:12 ` [PATCH 6/7] block: better op and flags encoding Christoph Hellwig
     [not found]   ` <CAJVOszBmN+=PD7MBEgkhO-jo3_R7rJ+5V1LGbWqDW8U+D=Dbgw@mail.gmail.com>
2016-10-28  7:35     ` Christoph Hellwig
2016-10-20 13:12 ` [PATCH 7/7] block: add a proper block layer data direction encoding Christoph Hellwig
2016-10-25 12:01 ` clean up block ops defintions Christoph Hellwig
2016-10-28 14:40   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476969135-32732-1-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.