All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 8/9] raw: Implement .bdrv_co_ioctl instead of .bdrv_aio_ioctl
Date: Thu, 20 Oct 2016 15:46:08 +0200	[thread overview]
Message-ID: <1476971169-31604-9-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1476971169-31604-1-git-send-email-kwolf@redhat.com>

It's the simpler interface to use for the raw format driver.

Apart from that, this removes the last user of the AIO emulation
implemented by bdrv_aio_ioctl().

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/raw_bsd.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 588d408..fc16ec1 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -176,12 +176,9 @@ static void raw_lock_medium(BlockDriverState *bs, bool locked)
     bdrv_lock_medium(bs->file->bs, locked);
 }
 
-static BlockAIOCB *raw_aio_ioctl(BlockDriverState *bs,
-                                 unsigned long int req, void *buf,
-                                 BlockCompletionFunc *cb,
-                                 void *opaque)
+static int raw_co_ioctl(BlockDriverState *bs, unsigned long int req, void *buf)
 {
-    return bdrv_aio_ioctl(bs->file->bs, req, buf, cb, opaque);
+    return bdrv_co_ioctl(bs->file->bs, req, buf);
 }
 
 static int raw_has_zero_init(BlockDriverState *bs)
@@ -261,7 +258,7 @@ BlockDriver bdrv_raw = {
     .bdrv_media_changed   = &raw_media_changed,
     .bdrv_eject           = &raw_eject,
     .bdrv_lock_medium     = &raw_lock_medium,
-    .bdrv_aio_ioctl       = &raw_aio_ioctl,
+    .bdrv_co_ioctl        = &raw_co_ioctl,
     .create_opts          = &raw_create_opts,
     .bdrv_has_zero_init   = &raw_has_zero_init
 };
-- 
1.8.3.1

  parent reply	other threads:[~2016-10-20 13:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 13:46 [Qemu-devel] [PATCH 0/9] block-backend: Use coroutine for flush/discard/ioctl Kevin Wolf
2016-10-20 13:46 ` [Qemu-devel] [PATCH 1/9] block: Use blk_co_flush() for all BB level flushes Kevin Wolf
2016-10-20 16:13   ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 2/9] block: Use blk_co_pdiscard() for all BB level discard Kevin Wolf
2016-10-20 16:18   ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard() Kevin Wolf
2016-10-20 17:32   ` Eric Blake
2016-10-21 10:59     ` Kevin Wolf
2016-10-21 13:45       ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 4/9] block: Use blk_co_ioctl() for all BB level ioctls Kevin Wolf
2016-10-20 17:40   ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 5/9] raw-posix: Don't use bdrv_ioctl() Kevin Wolf
2016-10-20 17:45   ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 6/9] block: Remove bdrv_ioctl() Kevin Wolf
2016-10-20 17:47   ` Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 7/9] block: Introduce .bdrv_co_ioctl() driver callback Kevin Wolf
2016-10-20 17:51   ` Eric Blake
2016-10-20 13:46 ` Kevin Wolf [this message]
2016-10-20 17:52   ` [Qemu-devel] [PATCH 8/9] raw: Implement .bdrv_co_ioctl instead of .bdrv_aio_ioctl Eric Blake
2016-10-20 13:46 ` [Qemu-devel] [PATCH 9/9] block: Remove bdrv_aio_ioctl() Kevin Wolf
2016-10-20 17:53   ` Eric Blake
2016-10-20 14:37 ` [Qemu-devel] [PATCH 0/9] block-backend: Use coroutine for flush/discard/ioctl Paolo Bonzini
2016-10-20 15:20 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476971169-31604-9-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.