From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbcJULhB (ORCPT ); Fri, 21 Oct 2016 07:37:01 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36045 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbcJULg7 (ORCPT ); Fri, 21 Oct 2016 07:36:59 -0400 Message-ID: <1477049817.7065.56.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump From: Eric Dumazet To: Jiri Kosina Cc: Jamal Hadi Salim , Phil Sutter , Cong Wang , Daniel Borkmann , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Fri, 21 Oct 2016 04:36:57 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-10-21 at 10:45 +0200, Jiri Kosina wrote: > The original reason [1] for having hidden qdiscs (potential scalability > issues in qdisc_match_from_root() with single linked list in case of large > amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert > qdisc linked list to hashtable"). > > This allows us for bringing more clarity and determinism into the dump by > making default pfifo qdiscs visible. > > [1] http://lkml.kernel.org/r/1460732328.10638.74.camel@edumazet-glaptop3.roam.corp.google.com > > Signed-off-by: Jiri Kosina > --- Some of us are dealing with huge HTB hierarchies, so adding default fifo in the dump will add more data pumped from the kernel. BwE [1] for instance dumps qdisc/classes every 5 seconds. I guess we'll need to not pull this patch in our kernels. This reminds me of an HTB patch to avoid dumping rate estimates for HTB. I will send it today. [1] http://static.googleusercontent.com/media/research.google.com/en//pubs/archive/43838.pdf