From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935188AbcJUPYS (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Oct 2016 11:24:18 -0400
Received: from mail-wm0-f41.google.com ([74.125.82.41]:34175 "EHLO
        mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934504AbcJUPYO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Oct 2016 11:24:14 -0400
Message-ID: <1477063451.8523.35.camel@gmail.com>
Subject: Re: 4.9 regression/bisection - 761ed4a94582 tty: serial_core:
 convert uart_close to use tty_port_close
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>
Date: Fri, 21 Oct 2016 17:24:11 +0200
In-Reply-To: <CAL_JsqKQVZTejA3tnC2q2_3w_McAPiSppXFiFyi3-3T5vdwnPg@mail.gmail.com>
References: <1477053923.8523.13.camel@gmail.com>
         <CAL_JsqKsMdarvdfL6LTejmBQNK1uOrBtB9X+dscOeESJqx0C-A@mail.gmail.com>
         <1477060817.8523.33.camel@gmail.com>
         <CAL_JsqKQVZTejA3tnC2q2_3w_McAPiSppXFiFyi3-3T5vdwnPg@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-10-21 at 10:00 -0500, Rob Herring wrote:
> On Fri, Oct 21, 2016 at 9:40 AM, Mike Galbraith
> <umgwanakikbuti@gmail.com> wrote:
> > On Fri, 2016-10-21 at 08:51 -0500, Rob Herring wrote:
> > > On Fri, Oct 21, 2016 at 7:45 AM, Mike Galbraith
> > > <umgwanakikbuti@gmail.com> wrote:
> > > > Greetings,
> > > > 
> > > > My old DL980 G7 is exploding on reboot with master, with only the first
> > > > couple lines actually making it to the console.  Once (and only once)
> > > > during bisection it did manage to get the below emitted.
> > > 
> > > Does this patch[1] fix things for you? Sorry, only the reply seems to
> > > be in the archives.
> > 
> > Nope, still went boom.
> 
> Can you try just removing the "port->console = uart_console(uport);"
> line completely?

That worked.

	-Mike