From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbbECTd3 (ORCPT ); Sun, 3 May 2015 15:33:29 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:40449 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbbECTdU (ORCPT ); Sun, 3 May 2015 15:33:20 -0400 From: Laurent Pinchart To: Nicholas Mc Guire , Kuninori Morimoto Cc: David Woodhouse , Brian Norris , Vinod Koul , Wolfram Sang , Arnd Bergmann , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable Date: Sun, 03 May 2015 22:33:43 +0300 Message-ID: <1477205.SvYxjlTIEF@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.11-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1430553430-21396-2-git-send-email-hofrat@osadl.org> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-2-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > shdma_tx_submit() called via dmaengine_submit() returns the assigned > cookie but this is not used here so the variable and assignment can > be dropped. > > Signed-off-by: Nicholas Mc Guire I would rephrase the commit message to avoid mentioning shdma_tx_submit() as that's not relevant. Something like "dmaengine_submit() returns the assigned cookie but this is not used here so the variable and assignment can be dropped." With that fixed, Acked-by: Laurent Pinchart > --- > > V2: As pointed out by Laurent Pinchart > the variable and assignment can be dropped but not the call to > dmaengine_submit(desc) - fixed up > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index 9b032dd..d1c46e5 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, struct dma_chan *chan; > enum dma_transfer_direction tr_dir; > dma_addr_t dma_addr; > - dma_cookie_t cookie = -EINVAL; > uint32_t reg; > int ret = 0; > unsigned long time_left; > @@ -377,7 +376,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, > > desc->callback = flctl_dma_complete; > desc->callback_param = flctl; > - cookie = dmaengine_submit(desc); > + dmaengine_submit(desc); > > dma_async_issue_pending(chan); > } else { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galahad.ideasonboard.com ([2001:4b98:dc2:45:216:3eff:febb:480d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yoze5-0005AQ-6w for linux-mtd@lists.infradead.org; Sun, 03 May 2015 19:33:46 +0000 From: Laurent Pinchart To: Nicholas Mc Guire , Kuninori Morimoto Subject: Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable Date: Sun, 03 May 2015 22:33:43 +0300 Message-ID: <1477205.SvYxjlTIEF@avalon> In-Reply-To: <1430553430-21396-2-git-send-email-hofrat@osadl.org> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-2-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: Arnd Bergmann , Wolfram Sang , Vinod Koul , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > shdma_tx_submit() called via dmaengine_submit() returns the assigned > cookie but this is not used here so the variable and assignment can > be dropped. > > Signed-off-by: Nicholas Mc Guire I would rephrase the commit message to avoid mentioning shdma_tx_submit() as that's not relevant. Something like "dmaengine_submit() returns the assigned cookie but this is not used here so the variable and assignment can be dropped." With that fixed, Acked-by: Laurent Pinchart > --- > > V2: As pointed out by Laurent Pinchart > the variable and assignment can be dropped but not the call to > dmaengine_submit(desc) - fixed up > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index 9b032dd..d1c46e5 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, struct dma_chan *chan; > enum dma_transfer_direction tr_dir; > dma_addr_t dma_addr; > - dma_cookie_t cookie = -EINVAL; > uint32_t reg; > int ret = 0; > unsigned long time_left; > @@ -377,7 +376,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, > > desc->callback = flctl_dma_complete; > desc->callback_param = flctl; > - cookie = dmaengine_submit(desc); > + dmaengine_submit(desc); > > dma_async_issue_pending(chan); > } else { -- Regards, Laurent Pinchart