From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bydZv-0007jQ-To for qemu-devel@nongnu.org; Mon, 24 Oct 2016 07:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bydZq-000108-7W for qemu-devel@nongnu.org; Mon, 24 Oct 2016 07:38:07 -0400 From: Kevin Wolf Date: Mon, 24 Oct 2016 13:37:46 +0200 Message-Id: <1477309068-1333-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1477309068-1333-1-git-send-email-kwolf@redhat.com> References: <1477309068-1333-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v5 2/4] qapi: fix memory leak in bdrv_image_info_specific_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com, fred.konrad@greensocs.com, qemu-devel@nongnu.org From: Pino Toscano The 'obj' result of the visitor was not properly freed, like done in other places doing a similar job. Signed-off-by: Pino Toscano Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi.c b/block/qapi.c index 6f947e3..50d3090 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function func_fprintf, void *f, assert(qobject_type(obj) == QTYPE_QDICT); data = qdict_get(qobject_to_qdict(obj), "data"); dump_qobject(func_fprintf, f, 1, data); + qobject_decref(obj); visit_free(v); } -- 1.8.3.1