All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: sumit.semwal@linaro.org
Cc: dri-devel@lists.freedesktop.org
Subject: Fixing zero timeout handling for fence functions
Date: Tue, 25 Oct 2016 14:25:07 +0200	[thread overview]
Message-ID: <1477398311-5218-1-git-send-email-deathsimple@vodafone.de> (raw)

Hi Sumit,

sending this once more with all the patches in once set, cause the last one
turned out to be a bit chaotic because I send from the wrong branch.

The following patch set fixes the handling in the fence and reservation object
wait function when the timeout is zero.

An AMD developer introduced this a while ago to work around some issues in TTM
and our amdgpu driver, but essentially this effort was a bit flawed because
even with a zero timeout enable_signalling() should be called.

Otherwise someone busy waiting for the fence might never be signaled when you
have hardware with faulty interrupts for example.

Please review and/or comment,
Christian.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-10-25 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 12:25 Christian König [this message]
2016-10-25 12:25 ` [PATCH 1/4] dma-buf/fence: make timeout handling in fence_default_wait consistent Christian König
2016-10-26  8:49   ` Chris Wilson
2016-10-26 13:27     ` Christian König
2016-10-25 12:25 ` [PATCH 2/4] dma-buf/fence: revert "don't wait when specified timeout is zero" Christian König
2016-10-25 12:25 ` [PATCH 3/4] drm/ttm: fix ttm_bo_wait Christian König
2016-10-25 12:25 ` [PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2 Christian König
2016-10-26  2:39 ` Fixing zero timeout handling for fence functions Sumit Semwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477398311-5218-1-git-send-email-deathsimple@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.