From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942014AbcJZMal (ORCPT ); Wed, 26 Oct 2016 08:30:41 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:53251 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941976AbcJZMah (ORCPT ); Wed, 26 Oct 2016 08:30:37 -0400 Message-ID: <1477485030.1951.13.camel@tiscali.nl> Subject: Re: [tip:x86/vdso] x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_* From: Paul Bolle To: dsafonov@virtuozzo.com, luto@kernel.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org Date: Wed, 26 Oct 2016 14:30:30 +0200 In-Reply-To: References: <20160905133308.28234-4-dsafonov@virtuozzo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is bit late, but we're still on v4.9-rc2, so anyhow. On Wed, 2016-09-14 at 12:34 -0700, tip-bot for Dmitry Safonov wrote: > Commit-ID:  2eefd8789698e89c4a5d610921dc3c1b66e3bd0d > Gitweb:     http://git.kernel.org/tip/2eefd8789698e89c4a5d610921dc3c1b66e3bd0d > Author:     Dmitry Safonov > AuthorDate: Mon, 5 Sep 2016 16:33:05 +0300 > Committer:  Thomas Gleixner > CommitDate: Wed, 14 Sep 2016 21:28:09 +0200 > > x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_* > > Add API to change vdso blob type with arch_prctl. > As this is usefull only by needs of CRIU, expose > this interface under CONFIG_CHECKPOINT_RESTORE. > > Signed-off-by: Dmitry Safonov > Acked-by: Andy Lutomirski > Cc: 0x7f454c46@gmail.com > Cc: oleg@redhat.com > Cc: linux-mm@kvack.org > Cc: gorcunov@openvz.org > Cc: xemul@virtuozzo.com > Link: http://lkml.kernel.org/r/20160905133308.28234-4-dsafonov@virtuozzo.com > Signed-off-by: Thomas Gleixner > --- a/arch/x86/include/uapi/asm/prctl.h > +++ b/arch/x86/include/uapi/asm/prctl.h >  #define ARCH_GET_FS 0x1003 >  #define ARCH_GET_GS 0x1004 >   > +#ifdef CONFIG_CHECKPOINT_RESTORE > +# define ARCH_MAP_VDSO_X32 0x2001 > +# define ARCH_MAP_VDSO_32 0x2002 > +# define ARCH_MAP_VDSO_64 0x2003 > +#endif > + >  #endif /* _ASM_X86_PRCTL_H */ On my machine this header ends up in /usr/include/asm/prctl.h. But in userspace CONFIG_CHECKPOINT_RESTORE is meaningless. I think if you actually want to export these three macros to userspace the guard should read:     #if defined(CONFIG_CHECKPOINT_RESTORE) || !defined(__KERNEL__) And if you don't want to export these macros the guard should read:     #if defined(CONFIG_CHECKPOINT_RESTORE) && defined(__KERNEL__) (In that case you're probably better of defining these macros outside of uapi.) I've only lightly tested those two alternatives, so please double check. Paul Bolle