From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzmHb-0002OA-3Z for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:07:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzmHW-0005lI-67 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:07:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48418) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzmHW-0005kl-1Q for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:07:50 -0400 Message-ID: <1477580867.9075.24.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 27 Oct 2016 17:07:47 +0200 In-Reply-To: <4B74416B-EEBE-408F-B589-41318045938D@gmail.com> References: <4B74416B-EEBE-408F-B589-41318045938D@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: G 3 Cc: qemu-devel qemu-devel , Samuel Thibault > > +# needed to make gcc accept wide unicode chars without warning > > +curses.o-cflags :=3D -std=3Dgnu99 > Could we add a commit message to this patch? It could answer =20 > questions like: >=20 > Why this patch is needed? > Who needs this patch? > What problem it solves. The comment added by the patch explains things. I could cut+paste that into the commit msg, but given how small the patch is it looked pointless to me ... cheers, Gerd