From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56587)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzn24-0008Jb-A5
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:56:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzn21-0003HW-1t
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:55:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55380)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1bzn20-0003H2-KR
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:55:52 -0400
Message-ID: <1477583747.9075.30.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 27 Oct 2016 17:55:47 +0200
In-Reply-To: <CAFEAcA-2DwW_ozvF-0EhepNzgPuN=F_HwDfoy8V06M6KzAoRTw@mail.gmail.com>
References: <1477568774-4817-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA-2DwW_ozvF-0EhepNzgPuN=F_HwDfoy8V06M6KzAoRTw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>

  Hi,

> > +# needed to make gcc accept wide unicode chars without warning
> > +curses.o-cflags :=3D -std=3Dgnu99
> > +
> >  ifeq ($(CONFIG_SDLABI),1.2)
> >  sdl.mo-objs :=3D sdl.o sdl_zoom.o
> >  endif
> > --
> > 1.8.3.1
>=20
> I'm not sure about this.
>=20
> Do we really want gnu99 and not c99? Should we just enable
> std=3Dc99 for all source files, given that we already assume
> C99 anyway?

-std=3Dc99 doesn't fly, throws errors on (gcc-specific) asm.
So we have to use -std=3Dgnu99.

Tried to do that tree-wide by patching configure but got build errors
then (somewhere in iscsi code).

> It would also be helpful if the commit message quoted the
> compiler warning that you get otherwise, so it's easier
> to see why we're doing this.

With the wide char curses patches by samuel applied I get errors like
this one:

/home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal
character names are only valid in C++ and C99 [-Werror]
             case L'\u23bd':
                  ^

I'm open to better ideas to handle this.

Failing that I can cut+paste this reply into the commit message to
clarify things.

cheers,
  Gerd