From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Convert breadcrumbs spinlock to be irqsafe
Date: Fri, 28 Oct 2016 14:41:07 +0300 [thread overview]
Message-ID: <1477654867.3965.1.camel@linux.intel.com> (raw)
In-Reply-To: <20161027161036.5443-1-chris@chris-wilson.co.uk>
On to, 2016-10-27 at 17:10 +0100, Chris Wilson wrote:
> @@ -473,14 +477,14 @@ static int intel_breadcrumbs_signaler(void *arg)
> * we just completed - so double check we are still
> * the oldest before picking the next one.
> */
> - spin_lock(&b->lock);
> + spin_lock_irqsave(&b->lock, flags);
With the convention discussed in IRC, this should be spin_lock_irq().
With that changed;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-28 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 16:10 [PATCH] drm/i915: Convert breadcrumbs spinlock to be irqsafe Chris Wilson
2016-10-27 16:48 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-10-28 9:42 ` [PATCH] " Tvrtko Ursulin
2016-10-28 10:10 ` Chris Wilson
2016-10-28 10:27 ` Tvrtko Ursulin
2016-10-28 10:42 ` Chris Wilson
2016-10-28 10:49 ` Tvrtko Ursulin
2016-10-28 11:26 ` Chris Wilson
2016-10-28 11:30 ` Chris Wilson
2016-10-28 11:40 ` Chris Wilson
2016-10-28 11:43 ` Tvrtko Ursulin
2016-10-28 11:26 ` [PATCH v2] drm: Add timestamp of last modification to GETCONNECTOR ioctl Chris Wilson
2016-10-28 11:32 ` Chris Wilson
2016-10-28 11:31 ` [PATCH v2] drm/i915: Convert breadcrumbs spinlock to be irqsafe and bhsafe Chris Wilson
2016-10-28 11:41 ` Joonas Lahtinen [this message]
2016-10-28 12:13 ` [PATCH v3] drm/i915: Convert breadcrumbs spinlock to be irqsafe Chris Wilson
2016-10-28 12:16 ` ✗ Fi.CI.BAT: failure for drm/i915: Convert breadcrumbs spinlock to be irqsafe (rev3) Patchwork
2016-10-28 13:15 ` ✗ Fi.CI.BAT: failure for drm/i915: Convert breadcrumbs spinlock to be irqsafe (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477654867.3965.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.