From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning
Date: Sat, 29 Oct 2016 08:49:23 -0700 [thread overview]
Message-ID: <1477756163.8025.0.camel@linux.intel.com> (raw)
In-Reply-To: <20161029111740.741-1-bp@alien8.de>
On Sat, 2016-10-29 at 13:17 +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix
>
> drivers/hid/intel-ish-hid/ipc/pci-ish.c:247:12: warning:
> ‘ish_suspend’ defined but not used [-Wunused-function]
> static int ish_suspend(struct device *device)
> ^
> drivers/hid/intel-ish-hid/ipc/pci-ish.c:282:12: warning:
> ‘ish_resume’ defined but not used [-Wunused-function]
> static int ish_resume(struct device *device)
> ^
> by sticking them in the CONFIG_PM range too.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>
> Cc: linux-input@vger.kernel.org
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>-
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 42f0beeb09fd..7e3622a724aa 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -202,6 +202,7 @@ static void ish_remove(struct pci_dev *pdev)
> kfree(ishtp_dev);
> }
>
> +#ifdef CONFIG_PM
> static struct device *ish_resume_device;
>
> /**
> @@ -293,7 +294,6 @@ static int ish_resume(struct device *device)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> static const struct dev_pm_ops ish_pm_ops = {
> .suspend = ish_suspend,
> .resume = ish_resume,
> @@ -301,7 +301,7 @@ static const struct dev_pm_ops ish_pm_ops = {
> #define ISHTP_ISH_PM_OPS (&ish_pm_ops)
> #else
> #define ISHTP_ISH_PM_OPS NULL
> -#endif
> +#endif /* CONFIG_PM */
>
> static struct pci_driver ish_driver = {
> .name = KBUILD_MODNAME,
next prev parent reply other threads:[~2016-10-29 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 11:17 [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning Borislav Petkov
2016-10-29 15:49 ` Srinivas Pandruvada [this message]
2016-11-03 18:12 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477756163.8025.0.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bp@alien8.de \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.