From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1H1o-0006t2-Iv for qemu-devel@nongnu.org; Mon, 31 Oct 2016 14:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1H1j-0004Qe-Fn for qemu-devel@nongnu.org; Mon, 31 Oct 2016 14:09:48 -0400 From: Ashijeet Acharya Date: Mon, 31 Oct 2016 23:36:54 +0530 Message-Id: <1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com> Subject: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: mreitz@redhat.com, rjones@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, Ashijeet Acharya This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and fixes the bug. Signed-off-by: Ashijeet Acharya --- block/ssh.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index ca071c5..15ed281 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts, return true; } -static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options, - Error **errp) +static InetSocketAddress *ssh_config(QDict *options, Error **errp) { InetSocketAddress *inet = NULL; QDict *addr = NULL; @@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options, } /* Pop the config into our state object, Exit if invalid */ - s->inet = ssh_config(s, options, errp); + s->inet = ssh_config(options, errp); if (!s->inet) { ret = -EINVAL; goto err; -- 2.6.2