From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 31 Oct 2016 14:39:18 -0600 Subject: [U-Boot] [PATCH 02/20] rockchip: video: Correct VOP clock selection In-Reply-To: <1477946376-29471-1-git-send-email-sjg@chromium.org> References: <1477946376-29471-1-git-send-email-sjg@chromium.org> Message-ID: <1477946376-29471-3-git-send-email-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de This code incorrectly uses the oscillator. It should use the clock selected in the device tree. Signed-off-by: Simon Glass Fixes: 135aa95 (clk: convert API to match reset/mailbox style) --- drivers/video/rockchip/rk_vop.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c index c6d88d9..130dace 100644 --- a/drivers/video/rockchip/rk_vop.c +++ b/drivers/video/rockchip/rk_vop.c @@ -195,7 +195,6 @@ int rk_display_init(struct udevice *dev, ulong fbbase, struct udevice *disp; int ret, remote, i, offset; struct display_plat *disp_uc_plat; - struct udevice *dev_clk; struct clk clk; vop_id = fdtdec_get_int(blob, ep_node, "reg", -1); @@ -238,11 +237,7 @@ int rk_display_init(struct udevice *dev, ulong fbbase, return ret; } - ret = rockchip_get_clk(&dev_clk); - if (!ret) { - clk.id = DCLK_VOP0 + remote_vop_id; - ret = clk_request(dev_clk, &clk); - } + ret = clk_get_by_index(dev, 1, &clk); if (!ret) ret = clk_set_rate(&clk, timing.pixelclock.typ); if (ret) { -- 2.8.0.rc3.226.g39d4020