From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:56607 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168052AbcKAJIA (ORCPT ); Tue, 1 Nov 2016 05:08:00 -0400 Message-ID: <1477991271.2230.40.camel@tiscali.nl> Subject: Re: [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things From: Paul Bolle To: Maarten Lankhorst , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Mika Kahola , bruno.pagani@ens-lyon.org, Daniel J Blueman , Joseph Yasi , stable@vger.kernel.org Date: Tue, 01 Nov 2016 10:07:51 +0100 In-Reply-To: <1354f7bd-a473-f941-cd79-d1fc7259fa38@linux.intel.com> References: <1477673960-3274-1-git-send-email-ville.syrjala@linux.intel.com> <1354f7bd-a473-f941-cd79-d1fc7259fa38@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2016-11-01 at 09:57 +0100, Maarten Lankhorst wrote: > Otherwise looks sane, I have a similar patch in my tree. I didn't > submit it yet but the fix was similar. Except for the > dev_cdclk stuff. > > With the last dev_cdclk assignment removed: > > Reviewed-by: Maarten Lankhorst So I've been running this patch for a few days now. First I tested it on top of v4.8.4. Now I'm running it on top of v4.8.5. My current v4.8.5 boot saw this new (for me) *ERROR*, twice:     <3>[43483.521341] [drm:skl_set_cdclk [i915]] *ERROR* failed to inform PCU about cdclk change <3>[108639.090776] [drm:skl_set_cdclk [i915]] *ERROR* failed to inform PCU about cdclk change Related or a coincidence? Thanks, Paul Bolle