All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 05/11] arm64: unexport walk_stackframe
Date: Thu,  3 Nov 2016 20:23:07 +0000	[thread overview]
Message-ID: <1478204593-29145-6-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1478204593-29145-1-git-send-email-mark.rutland@arm.com>

The walk_stackframe functions is architecture-specific, with a varying
prototype, and common code should not use it directly. None of its
current users can be built as modules. With THREAD_INFO_IN_TASK, users
will also need to hold a stack reference before calling it.

There's no reason for it to be exported, and it's very easy to misuse,
so unexport it for now.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm64/kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 5b80068..d53f99d 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -129,7 +129,6 @@ void notrace walk_stackframe(struct task_struct *tsk, struct stackframe *frame,
 			break;
 	}
 }
-EXPORT_SYMBOL(walk_stackframe);
 
 #ifdef CONFIG_STACKTRACE
 struct stack_trace_data {
-- 
2.7.4

  parent reply	other threads:[~2016-11-03 20:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 20:23 [PATCHv2 00/11] arm64: move thread_info off of the task stack Mark Rutland
2016-11-03 20:23 ` [PATCHv2 01/11] arm64: thread_info remove stale items Mark Rutland
2016-11-03 20:23 ` [PATCHv2 02/11] arm64: asm-offsets: remove unused definitions Mark Rutland
2016-11-03 20:23 ` [PATCHv2 03/11] arm64: factor out current_stack_pointer Mark Rutland
2016-11-03 20:23 ` [PATCHv2 04/11] arm64: traps: simplify die() and __die() Mark Rutland
2016-11-03 20:23 ` Mark Rutland [this message]
2016-11-03 20:23 ` [PATCHv2 06/11] arm64: prep stack walkers for THREAD_INFO_IN_TASK Mark Rutland
2016-11-03 20:23 ` [PATCHv2 07/11] arm64: move sp_el0 and tpidr_el1 into cpu_suspend_ctx Mark Rutland
2016-11-03 20:23 ` [PATCHv2 08/11] arm64: smp: prepare for smp_processor_id() rework Mark Rutland
2016-11-03 20:23 ` [PATCHv2 09/11] arm64: make cpu number a percpu variable Mark Rutland
2016-11-03 20:23 ` [PATCHv2 10/11] arm64: assembler: introduce ldr_this_cpu Mark Rutland
2016-11-03 20:23 ` [PATCHv2 11/11] arm64: split thread_info from task stack Mark Rutland
2016-11-14 17:50 ` [PATCHv2 00/11] arm64: move thread_info off of the " Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478204593-29145-6-git-send-email-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.