All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Wang Nan <wangnan0@huawei.com>, Nambong Ha <over3025@gmail.com>,
	Wookje Kwon <aweee0@gmail.com>,
	Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH 1/6] perf config: Add support for getting config key-value pairs
Date: Fri,  4 Nov 2016 15:44:17 +0900	[thread overview]
Message-ID: <1478241862-31230-2-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1478241862-31230-1-git-send-email-treeze.taeung@gmail.com>

Add a functionality getting specific config key-value pairs.
For the syntax examples,

    perf config [<file-option>] [section.name ...]

e.g. To query config items 'report.queue-size' and 'report.children', do

    # perf config report.queue-size report.children

Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/builtin-config.c | 40 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 37 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index e4207a2..df3fa1c 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -17,7 +17,7 @@
 static bool use_system_config, use_user_config;
 
 static const char * const config_usage[] = {
-	"perf config [<file-option>] [options]",
+	"perf config [<file-option>] [options] [section.name ...]",
 	NULL
 };
 
@@ -33,6 +33,36 @@ static struct option config_options[] = {
 	OPT_END()
 };
 
+static int show_spec_config(struct perf_config_set *set, const char *var)
+{
+	struct perf_config_section *section;
+	struct perf_config_item *item;
+
+	if (set == NULL)
+		return -1;
+
+	perf_config_items__for_each_entry(&set->sections, section) {
+		if (prefixcmp(var, section->name) != 0)
+			continue;
+
+		perf_config_items__for_each_entry(&section->items, item) {
+			const char *name = var + strlen(section->name) + 1;
+
+			if (strcmp(name, item->name) == 0) {
+				char *value = item->value;
+
+				if (value) {
+					printf("%s=%s\n", var, value);
+					return 0;
+				}
+			}
+
+		}
+	}
+
+	return 0;
+}
+
 static int show_config(struct perf_config_set *set)
 {
 	struct perf_config_section *section;
@@ -54,7 +84,7 @@ static int show_config(struct perf_config_set *set)
 
 int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
 {
-	int ret = 0;
+	int i, ret = 0;
 	struct perf_config_set *set;
 	char *user_config = mkpath("%s/.perfconfig", getenv("HOME"));
 
@@ -100,7 +130,11 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
 		}
 		break;
 	default:
-		usage_with_options(config_usage, config_options);
+		if (argc)
+			for (i = 0; argv[i]; i++)
+				ret = show_spec_config(set, argv[i]);
+		else
+			usage_with_options(config_usage, config_options);
 	}
 
 	perf_config_set__delete(set);
-- 
2.7.4

  reply	other threads:[~2016-11-04  6:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  6:44 [PATCH 0/6] perf config: Add support for setting and getting functionalities Taeung Song
2016-11-04  6:44 ` Taeung Song [this message]
2016-11-14 15:50   ` [PATCH 1/6] perf config: Add support for getting config key-value pairs Arnaldo Carvalho de Melo
2016-11-14 16:21     ` Taeung Song
2016-11-28  9:02     ` Taeung Song
2016-11-15 10:44   ` [tip:perf/core] " tip-bot for Taeung Song
2016-11-04  6:44 ` [PATCH 2/6] perf config: Document examples to get config key-value pairs in man page Taeung Song
2016-11-14 15:51   ` Arnaldo Carvalho de Melo
2016-11-14 16:30     ` Taeung Song
2016-11-04  6:44 ` [PATCH 3/6] perf config: Parse config variable arguments before getting functionality Taeung Song
2016-11-15 10:44   ` [tip:perf/core] perf config: Validate config variable arguments before trying use them tip-bot for Taeung Song
2016-11-04  6:44 ` [PATCH 4/6] perf config: Add support for writing configs to a config file Taeung Song
2016-11-14 16:04   ` Arnaldo Carvalho de Melo
2016-11-14 17:00     ` Taeung Song
2016-11-15  1:49       ` Arnaldo Carvalho de Melo
2016-11-15  2:28         ` Taeung Song
2016-11-15 10:45   ` [tip:perf/core] perf config: Add support setting variables in " tip-bot for Taeung Song
2016-11-04  6:44 ` [PATCH 5/6] perf config: Document examples to set config variables with values in man page Taeung Song
2016-11-04  6:44 ` [PATCH 6/6] perf config: Mark where are config items from (user or system) Taeung Song
2016-11-15 10:46   ` [tip:perf/core] " tip-bot for Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478241862-31230-2-git-send-email-treeze.taeung@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=aweee0@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=over3025@gmail.com \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.