From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5GI5-00077Y-Us for qemu-devel@nongnu.org; Fri, 11 Nov 2016 13:11:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5GI5-0003ln-0q for qemu-devel@nongnu.org; Fri, 11 Nov 2016 13:11:05 -0500 Received: from mail.kernel.org ([198.145.29.136]:52506) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c5GI4-0003lS-Rz for qemu-devel@nongnu.org; Fri, 11 Nov 2016 13:11:04 -0500 Date: Fri, 11 Nov 2016 20:11:00 +0200 From: "Michael S. Tsirkin" Message-ID: <1478887767-31980-21-git-send-email-mst@redhat.com> References: <1478887767-31980-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478887767-31980-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PULL v2 20/34] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Xiao Guangrong , Igor Mammedov , Stefan Hajnoczi , Paolo Bonzini , Richard Henderson , Eduardo Habkost From: Xiao Guangrong as it is never called when nvdimm hotplug happens Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index cebaad2..b69cd48 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1761,12 +1761,6 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev, HotplugHandlerClass *hhc; Error *local_err = NULL; - if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { - error_setg(&local_err, - "nvdimm device hot unplug is not supported yet."); - goto out; - } - hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); hhc->unplug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); -- MST