From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966169AbcKLBYI (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Nov 2016 20:24:08 -0500
Received: from mga11.intel.com ([192.55.52.93]:32229 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965980AbcKLBYH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Nov 2016 20:24:07 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,475,1473145200"; 
   d="scan'208";a="900563561"
Message-ID: <1478913845.2541.0.camel@ranerica-desktop>
Subject: Re: [PATCH 1/4] x86/cpufeature: Add User-Mode Instruction
 Prevention definitions
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chen Yucong <slaoub@gmail.com>,
        Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Ravi V . Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>, Vlastimil Babka <vbabka@suse.cz>
Date: Fri, 11 Nov 2016 17:24:05 -0800
In-Reply-To: <20161111102255.dabxedhs7kgkn7d2@pd.tnic>
References: <1478585533-19406-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
         <1478585533-19406-2-git-send-email-ricardo.neri-calderon@linux.intel.com>
         <CALCETrXGFm8pFzn3qCr_k7n=9OUiKtFXRT0bg6TebnrxkTeMRQ@mail.gmail.com>
         <1478665516.2533.2.camel@ranerica-desktop>
         <CALCETrXp-Xy+cWuJUakBoXWTu0oWDbX3zCK12u5-QJ4P-7TfdA@mail.gmail.com>
         <1478748283.2551.5.camel@ranerica-desktop>
         <20161110085833.zw6qgd7pshbni656@pd.tnic>
         <1478837287.2542.4.camel@ranerica-desktop>
         <20161111102255.dabxedhs7kgkn7d2@pd.tnic>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-11-11 at 11:22 +0100, Borislav Petkov wrote:
> On Thu, Nov 10, 2016 at 08:08:07PM -0800, Ricardo Neri wrote:
> > UMIP is enabled by setting a bit in CR4. If that bit is not supposed
> > to be set, that could cause a #GP fault.
> 
> Yeah, you do check CPUID first, AFAICT, so you should be ok...

Right. I missed this detail. Yes, there should not be a problem.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)