From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941395AbcKOIqj convert rfc822-to-8bit (ORCPT ); Tue, 15 Nov 2016 03:46:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941202AbcKOIqg (ORCPT ); Tue, 15 Nov 2016 03:46:36 -0500 Message-ID: <1479199588.32639.16.camel@redhat.com> Subject: Re: BUG: 'list_empty(&vgdev->free_vbufs)' is true! From: Gerd Hoffmann To: Jiri Slaby Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, Linux kernel mailing list , David Airlie , dri-devel@lists.freedesktop.org Date: Tue, 15 Nov 2016 09:46:28 +0100 In-Reply-To: References: <20161108223153-mutt-send-email-mst@kernel.org> <1478678517.2078.12.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 15 Nov 2016 08:46:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: > On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: > > On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: > >> On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: > >>> Hi, > >>> > >>> I can relatively easily reproduce this bug: > > > > How? > > Run dmesg -w in the qemu window (virtio_gpu) to see a lot of output. fbcon? Or xorg/wayland with terminal app? > Run pps [1] without exit(0); on e.g. serial console. > Wait a bit. The lot of output causes the BUG. > > [1] https://github.com/jirislaby/collected_sources/blob/master/pps.c > > >>> BUG: 'list_empty(&vgdev->free_vbufs)' is true! > > > >> The following might be helpful for debugging - if kernel still will > >> not stop panicing, we are looking at some kind > >> of memory corruption. > > > > Looking carefully through the code I think it isn't impossible to > > trigger this, but you need for that: > > > > (1) command queue full (quite possible), > > (2) cursor queue full too (unlikely), and > > (3) multiple threads trying to submit commands and waiting for free > > space in the command queue (possible with virgl enabled). > > I use -vga virtio with no -display option, so no virtgl, I suppose: > [drm] virgl 3d acceleration not available > > > Do things improve if you allocate some extra bufs? > > > > int virtio_gpu_alloc_vbufs(struct virtio_gpu_device *vgdev) > > { > > struct virtio_gpu_vbuffer *vbuf; > > - int i, size, count = 0; > > + int i, size, count = 16; > > This seems to help. > > thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: BUG: 'list_empty(&vgdev->free_vbufs)' is true! Date: Tue, 15 Nov 2016 09:46:28 +0100 Message-ID: <1479199588.32639.16.camel@redhat.com> References: <20161108223153-mutt-send-email-mst@kernel.org> <1478678517.2078.12.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 578036E569 for ; Tue, 15 Nov 2016 08:46:36 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jiri Slaby Cc: virtualization@lists.linux-foundation.org, Linux kernel mailing list , dri-devel@lists.freedesktop.org, "Michael S. Tsirkin" List-Id: dri-devel@lists.freedesktop.org T24gRnIsIDIwMTYtMTEtMTEgYXQgMTc6MjggKzAxMDAsIEppcmkgU2xhYnkgd3JvdGU6Cj4gT24g MTEvMDkvMjAxNiwgMDk6MDEgQU0sIEdlcmQgSG9mZm1hbm4gd3JvdGU6Cj4gPiBPbiBEaSwgMjAx Ni0xMS0wOCBhdCAyMjozNyArMDIwMCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ID4+IE9u IE1vbiwgTm92IDA3LCAyMDE2IGF0IDA5OjQzOjI0QU0gKzAxMDAsIEppcmkgU2xhYnkgd3JvdGU6 Cj4gPj4+IEhpLAo+ID4+Pgo+ID4+PiBJIGNhbiByZWxhdGl2ZWx5IGVhc2lseSByZXByb2R1Y2Ug dGhpcyBidWc6Cj4gPiAKPiA+IEhvdz8KPiAKPiBSdW4gZG1lc2cgLXcgaW4gdGhlIHFlbXUgd2lu ZG93ICh2aXJ0aW9fZ3B1KSB0byBzZWUgYSBsb3Qgb2Ygb3V0cHV0LgoKZmJjb24/ICBPciB4b3Jn L3dheWxhbmQgd2l0aCB0ZXJtaW5hbCBhcHA/Cgo+IFJ1biBwcHMgWzFdIHdpdGhvdXQgZXhpdCgw KTsgb24gZS5nLiBzZXJpYWwgY29uc29sZS4KPiBXYWl0IGEgYml0LiBUaGUgbG90IG9mIG91dHB1 dCBjYXVzZXMgdGhlIEJVRy4KPiAKPiBbMV0gaHR0cHM6Ly9naXRodWIuY29tL2ppcmlzbGFieS9j b2xsZWN0ZWRfc291cmNlcy9ibG9iL21hc3Rlci9wcHMuYwo+IAo+ID4+PiBCVUc6ICdsaXN0X2Vt cHR5KCZ2Z2Rldi0+ZnJlZV92YnVmcyknIGlzIHRydWUhCj4gPiAKPiA+PiBUaGUgZm9sbG93aW5n IG1pZ2h0IGJlIGhlbHBmdWwgZm9yIGRlYnVnZ2luZyAtIGlmIGtlcm5lbCBzdGlsbCB3aWxsCj4g Pj4gbm90IHN0b3AgcGFuaWNpbmcsIHdlIGFyZSBsb29raW5nIGF0IHNvbWUga2luZAo+ID4+IG9m IG1lbW9yeSBjb3JydXB0aW9uLgo+ID4gCj4gPiBMb29raW5nIGNhcmVmdWxseSB0aHJvdWdoIHRo ZSBjb2RlIEkgdGhpbmsgaXQgaXNuJ3QgaW1wb3NzaWJsZSB0bwo+ID4gdHJpZ2dlciB0aGlzLCBi dXQgeW91IG5lZWQgZm9yIHRoYXQ6Cj4gPiAKPiA+ICAgKDEpIGNvbW1hbmQgcXVldWUgZnVsbCAo cXVpdGUgcG9zc2libGUpLAo+ID4gICAoMikgY3Vyc29yIHF1ZXVlIGZ1bGwgdG9vICh1bmxpa2Vs eSksIGFuZAo+ID4gICAoMykgbXVsdGlwbGUgdGhyZWFkcyB0cnlpbmcgdG8gc3VibWl0IGNvbW1h bmRzIGFuZCB3YWl0aW5nIGZvciBmcmVlCj4gPiAgICAgICBzcGFjZSBpbiB0aGUgY29tbWFuZCBx dWV1ZSAocG9zc2libGUgd2l0aCB2aXJnbCBlbmFibGVkKS4KPiAKPiBJIHVzZSAtdmdhIHZpcnRp byB3aXRoIG5vIC1kaXNwbGF5IG9wdGlvbiwgc28gbm8gdmlydGdsLCBJIHN1cHBvc2U6Cj4gW2Ry bV0gdmlyZ2wgM2QgYWNjZWxlcmF0aW9uIG5vdCBhdmFpbGFibGUKPiAKPiA+IERvIHRoaW5ncyBp bXByb3ZlIGlmIHlvdSBhbGxvY2F0ZSBzb21lIGV4dHJhIGJ1ZnM/Cj4gPiAKPiA+ICBpbnQgdmly dGlvX2dwdV9hbGxvY192YnVmcyhzdHJ1Y3QgdmlydGlvX2dwdV9kZXZpY2UgKnZnZGV2KQo+ID4g IHsKPiA+ICAgICAgICAgc3RydWN0IHZpcnRpb19ncHVfdmJ1ZmZlciAqdmJ1ZjsKPiA+IC0gICAg ICAgaW50IGksIHNpemUsIGNvdW50ID0gMDsKPiA+ICsgICAgICAgaW50IGksIHNpemUsIGNvdW50 ID0gMTY7Cj4gCj4gVGhpcyBzZWVtcyB0byBoZWxwLgo+IAo+IHRoYW5rcywKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=