Re: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling
Message-id: 1479248275-18889-1-git-send-email-david@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1479248275-18889-1-git-send-email-david@gibson.dropbear.id.au -> patchew/1479248275-18889-1-git-send-email-david@gibson.dropbear.id.au
Switched to a new branch 'test'
a010098 ppc: Rework CPU compatibility testing across migration
830db0f pseries: Reset CPU compatibility mode
d9b2e5df pseries: Move CPU compatibility property to machine
9a1ead7 ppc: Add ppc_set_compat_all()
b9341d5 pseries: Rewrite CAS PVR compatibility logic
e183845 ppc: Validate compatibility modes when setting
0c10a17 ppc: Rewrite ppc_get_compat_smt_threads()
6741d99 ppc: Rewrite ppc_set_compat()
28872e9 ppc: Rename cpu_version to compat_pvr
6662209 ppc: Clean up and QOMify hypercall emulation
8235268 pseries: Make cpu_update during CAS unconditional
b8093c5 pseries: Always use core objects for CPU construction

=== OUTPUT BEGIN ===
Checking PATCH 1/12: pseries: Always use core objects for CPU construction...
Checking PATCH 2/12: pseries: Make cpu_update during CAS unconditional...
Checking PATCH 3/12: ppc: Clean up and QOMify hypercall emulation...
Checking PATCH 4/12: ppc: Rename cpu_version to compat_pvr...
Checking PATCH 5/12: ppc: Rewrite ppc_set_compat()...
Checking PATCH 6/12: ppc: Rewrite ppc_get_compat_smt_threads()...
Checking PATCH 7/12: ppc: Validate compatibility modes when setting...
Checking PATCH 8/12: pseries: Rewrite CAS PVR compatibility logic...
ERROR: suspect code indent for conditional statements (4, 9)
#144: FILE: hw/ppc/spapr_hcall.c:937:
+    if ((best_compat == 0)
[...]
+         /* We couldn't find a suitable compatibility mode, and either

total: 1 errors, 0 warnings, 140 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/12: ppc: Add ppc_set_compat_all()...
Checking PATCH 10/12: pseries: Move CPU compatibility property to machine...
ERROR: line over 90 characters
#370: FILE: target-ppc/translate_init.c:8445:
+    error_report("CPU 'compat' property is deprecated and has no effect; use max-cpu-compat machine property instead");

total: 1 errors, 0 warnings, 330 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/12: pseries: Reset CPU compatibility mode...
Checking PATCH 12/12: ppc: Rework CPU compatibility testing across migration...
ERROR: braces {} are necessary for all arms of this statement
#98: FILE: target-ppc/machine.c:207:
+    if (cpu->compat_pvr) {
[...]
+    } else
[...]

total: 1 errors, 0 warnings, 126 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org