All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH 2/2] tpm: Fix error code handling after tpm_bios_log_setup
Date: Thu, 17 Nov 2016 19:30:04 -0500	[thread overview]
Message-ID: <1479429004-7962-2-git-send-email-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <1479429004-7962-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

tpm_bios_log_setup() may return -ENODEV in case no log was
found. In this case we do not need to fail the device.

Signed-off-by: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 drivers/char/tpm/tpm-chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 3f27753..2d6530b 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -346,7 +346,7 @@ int tpm_chip_register(struct tpm_chip *chip)
 	tpm_sysfs_add_device(chip);
 
 	rc = tpm_bios_log_setup(chip);
-	if (rc == -ENODEV)
+	if (rc != -ENODEV)
 		return rc;
 
 	tpm_add_ppi(chip);
-- 
2.4.3


------------------------------------------------------------------------------

  parent reply	other threads:[~2016-11-18  0:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  0:30 [PATCH 1/2] tpm: Check for parent device being NULL Stefan Berger
     [not found] ` <1479429004-7962-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-18  0:30   ` Stefan Berger [this message]
     [not found]     ` <1479429004-7962-2-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-18 12:26       ` [PATCH 2/2] tpm: Fix error code handling after tpm_bios_log_setup Nayna
2016-11-18 15:52     ` Jarkko Sakkinen
2016-11-19 18:22       ` Jason Gunthorpe
2016-11-20  9:46         ` Jarkko Sakkinen
2016-11-20  9:47           ` Jarkko Sakkinen
2016-11-20 12:14         ` Jarkko Sakkinen
     [not found]           ` <20161120121451.awcraondhcvzpbig-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-21 17:55             ` Jason Gunthorpe
2016-11-21 20:30               ` Jarkko Sakkinen
     [not found]               ` <20161121175520.GA24191-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-21 20:32                 ` Jarkko Sakkinen
2016-11-21 20:36                   ` Jarkko Sakkinen
2016-11-21 20:37                   ` Jason Gunthorpe
     [not found]                     ` <20161121203708.GA7294-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-21 20:46                       ` Jarkko Sakkinen
2016-11-21 20:56                         ` Jason Gunthorpe
2016-11-20 18:36         ` Nayna
2016-11-21 17:15           ` Jason Gunthorpe
2016-11-21 20:29             ` Jarkko Sakkinen
2016-11-22 16:37               ` Jason Gunthorpe
     [not found]                 ` <20161122163720.GB3956-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-22 16:48                   ` Jarkko Sakkinen
2016-11-22  9:04             ` Nayna
2016-11-18 15:52   ` [PATCH 1/2] tpm: Check for parent device being NULL Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479429004-7962-2-git-send-email-stefanb@linux.vnet.ibm.com \
    --to=stefanb-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.