From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1c8pEH-00078c-HB for mharc-grub-devel@gnu.org; Mon, 21 Nov 2016 09:05:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8pEF-00077h-1j for grub-devel@gnu.org; Mon, 21 Nov 2016 09:05:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8pE9-0007H4-Hs for grub-devel@gnu.org; Mon, 21 Nov 2016 09:05:51 -0500 Received: from mga01.intel.com ([192.55.52.88]:42287) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c8pE9-00076K-9w for grub-devel@gnu.org; Mon, 21 Nov 2016 09:05:45 -0500 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 21 Nov 2016 06:05:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,675,1473145200"; d="scan'208";a="903945826" Received: from jlahtine-desk.ger.corp.intel.com ([10.252.24.162]) by orsmga003.jf.intel.com with ESMTP; 21 Nov 2016 06:05:20 -0800 Message-ID: <1479737119.3256.7.camel@linux.intel.com> Subject: Re: [PATCH v2] serial: Poll USB devices if usbX serial port is missing From: Joonas Lahtinen To: Andrei Borzenkov Cc: The development of GNU GRUB Date: Mon, 21 Nov 2016 16:05:19 +0200 In-Reply-To: References: <7b9507a2-8bd4-2da7-8a04-333377e42bec@gmail.com> <1479465398-23174-1-git-send-email-joonas.lahtinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 14:05:52 -0000 On pe, 2016-11-18 at 15:21 +0300, Andrei Borzenkov wrote: > On Fri, Nov 18, 2016 at 1:36 PM, Joonas Lahtinen > > > > v2: > > - Use grub_term_poll_usb to avoid module dependency (Andrei) > > > > Hmm ... note that terminal_input/terminal_output also auto-load > modules that handle serial ports. So this still will not be > equivalent, it will require user to manually pre-load USB. Did you > actually test this version of patch? Do you pre-load USB modules > somewhere? Nope, I took your word literally and just changed the function. Assuming it's a rather direct replacement. Excuse for that. > > The problem is, infrastructure to handle auto-load lists currently > belongs to normal mode, while serial may sensibly be used before > normal is loaded. Not sure what we can do here. I think this is getting more important when we're seeing increasing amount of devices without even an internal serial port. Sounds to me like pulling the auto-loading out of just normal mode would make sense? Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation