From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH V2 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads Date: Tue, 22 Nov 2016 01:45:57 -0800 Message-ID: <1479807957.1942.9.camel@perches.com> References: <1478696782-11657-1-git-send-email-ldewangan@nvidia.com> <1478696782-11657-3-git-send-email-ldewangan@nvidia.com> <29e19381-9250-3059-b083-49e8ab56ea7f@nvidia.com> <5833FE99.2020004@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5833FE99.2020004-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , Jon Hunter , linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Tue, 2016-11-22 at 13:45 +0530, Laxman Dewangan wrote: > On Tuesday 22 November 2016 02:31 AM, Jon Hunter wrote: > > On 09/11/16 13:06, Laxman Dewangan wrote: > > + _entry_(32, "uart", UART, true, "vddio-uart"), \ > > + _entry_(33, "usb0", USB0, true, NULL), \ > > + _entry_(34, "usb1", USB1, true, NULL), \ > > + _entry_(35, "usb2", USB2, true, NULL), \ > > + _entry_(36, "usb3", USB3, true, NULL), \ > > + _entry_(37, "usb-bias", USB_BIAS, true, NULL) > > Can you also fix these checkpatch errors ... > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #424: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:350: > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #456: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:382: > > I can fix this but will still have the error as: > > CHECK: Macro argument reuse '_entry_' - possible side-effects? > #425: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:425: > > > And there is no better way to fix this. It's a stupid little script, feel free to ignore it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932489AbcKVJqF (ORCPT ); Tue, 22 Nov 2016 04:46:05 -0500 Received: from smtprelay0197.hostedemail.com ([216.40.44.197]:33677 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755827AbcKVJqC (ORCPT ); Tue, 22 Nov 2016 04:46:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:966:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2551:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:4321:4385:5007:7875:10004:10400:10848:11232:11658:11914:12043:12048:12050:12740:12760:13069:13255:13311:13357:13439:14659:14721:21080:21451:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: level43_8b863a7633c5b X-Filterd-Recvd-Size: 2303 Message-ID: <1479807957.1942.9.camel@perches.com> Subject: Re: [PATCH V2 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads From: Joe Perches To: Laxman Dewangan , Jon Hunter , linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, swarren@wwwdotorg.org, thierry.reding@gmail.com Cc: gnurou@gmail.com, yamada.masahiro@socionext.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Nov 2016 01:45:57 -0800 In-Reply-To: <5833FE99.2020004@nvidia.com> References: <1478696782-11657-1-git-send-email-ldewangan@nvidia.com> <1478696782-11657-3-git-send-email-ldewangan@nvidia.com> <29e19381-9250-3059-b083-49e8ab56ea7f@nvidia.com> <5833FE99.2020004@nvidia.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-11-22 at 13:45 +0530, Laxman Dewangan wrote: > On Tuesday 22 November 2016 02:31 AM, Jon Hunter wrote: > > On 09/11/16 13:06, Laxman Dewangan wrote: > > + _entry_(32, "uart", UART, true, "vddio-uart"), \ > > + _entry_(33, "usb0", USB0, true, NULL), \ > > + _entry_(34, "usb1", USB1, true, NULL), \ > > + _entry_(35, "usb2", USB2, true, NULL), \ > > + _entry_(36, "usb3", USB3, true, NULL), \ > > + _entry_(37, "usb-bias", USB_BIAS, true, NULL) > > Can you also fix these checkpatch errors ... > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #424: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:350: > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #456: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:382: > > I can fix this but will still have the error as: > > CHECK: Macro argument reuse '_entry_' - possible side-effects? > #425: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:425: > > > And there is no better way to fix this. It's a stupid little script, feel free to ignore it.